Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Park admittance price can now be set via text input #21734

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rik-smeets
Copy link
Contributor

Like with ride prices, the park admittrance price can now be set via text input by clicking on the price in the window.

Please note that this change does allow entrance fees to have a fractional part (like € 10.10 for example). If this isn't desirable please let me know.

@tupaschoal
Copy link
Member

Please note that this change does allow entrance fees to have a fractional part (like € 10.10 for example). If this isn't desirable please let me know.

I'd say that if it does change the behavior, it should at least be two different commits, one for setting via text input and another for "freeing" the decimals.

@rik-smeets
Copy link
Contributor Author

There wasn't any change done to allow the park admittance price to have a fraction. It's just that as of now (as for as I know) there's no way to set a fraction, since the + and - buttons next to the park entrance always increase/decrease by exactly 1.

Copy link
Member

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, could do with a bit of testing.

@Gymnasiast Gymnasiast added this to the v0.4.11 milestone Apr 6, 2024
@Gymnasiast Gymnasiast enabled auto-merge (squash) April 12, 2024 18:16
@Gymnasiast Gymnasiast merged commit 953bb4e into OpenRCT2:develop Apr 12, 2024
22 checks passed
@rik-smeets rik-smeets deleted the park-admittance-price branch April 14, 2024 07:48
janisozaur added a commit that referenced this pull request May 5, 2024
- Feature: [#11512] Coloured usernames by group on multiplayer servers.
- Feature: [#21734] Park admittance price can now be set via text input.
- Feature: [#21957] [Plugin] Expose whether the game is paused to the plugin API.
- Improved: [#21728] “Fix all rides” cheat now also works if a mechanic is already fixing the ride.
- Improved: [#21769] Expose “animation is backwards” wall property in Tile Inspector.
- Improved: [#21855] Add a separator between “Load Game” and “Save Game”, to avoid accidental overwriting.
- Change: [#21715] [Plugin] Remove access to the internal `owner` property. Note: `ownership` is still accessible.
- Change: [#21855] Cheats menu dropdown no longer requires dragging.
- Change: [#21866] Hide the FPS Counter when the top toolbar/widgets have been toggled off.
- Change: [#21950] Construction and removal buttons can now be held down for repeated placement.
- Fix: [#866] Boat Hire boats get stuck entering track (original bug).
- Fix: [#10701] No reason specified when placing door over unsuitable track.
- Fix: [#18723, #21870] Attempting to demolish a flat ride in pause mode allows you to place multiple copies.
- Fix: [#19559] Custom rides with long descriptions extend into lower widgets.
- Fix: [#21696] Fullscreen window option not correctly applied on macOS.
- Fix: [#21749] Crash when loading park bigger than current limits.
- Fix: [#21787] Map generator heightmap should respect increased height limits.
- Fix: [#21829] When creating a new scenario, the default name contains formatting codes.
- Fix: [#21937] Build errors with the ORIGINAL_RATINGS flag.
- Fix: [objects#324] Cannot build Colosseum inside a turn or helix.
- Fix: [objects#325] Sloped castle walls are vertically offset by one pixel (original bug).
mrmbernardi pushed a commit to mrmbernardi/OpenRCT2 that referenced this pull request May 10, 2024
- Feature: [OpenRCT2#11512] Coloured usernames by group on multiplayer servers.
- Feature: [OpenRCT2#21734] Park admittance price can now be set via text input.
- Feature: [OpenRCT2#21957] [Plugin] Expose whether the game is paused to the plugin API.
- Improved: [OpenRCT2#21728] “Fix all rides” cheat now also works if a mechanic is already fixing the ride.
- Improved: [OpenRCT2#21769] Expose “animation is backwards” wall property in Tile Inspector.
- Improved: [OpenRCT2#21855] Add a separator between “Load Game” and “Save Game”, to avoid accidental overwriting.
- Change: [OpenRCT2#21715] [Plugin] Remove access to the internal `owner` property. Note: `ownership` is still accessible.
- Change: [OpenRCT2#21855] Cheats menu dropdown no longer requires dragging.
- Change: [OpenRCT2#21866] Hide the FPS Counter when the top toolbar/widgets have been toggled off.
- Change: [OpenRCT2#21950] Construction and removal buttons can now be held down for repeated placement.
- Fix: [OpenRCT2#866] Boat Hire boats get stuck entering track (original bug).
- Fix: [OpenRCT2#10701] No reason specified when placing door over unsuitable track.
- Fix: [OpenRCT2#18723, OpenRCT2#21870] Attempting to demolish a flat ride in pause mode allows you to place multiple copies.
- Fix: [OpenRCT2#19559] Custom rides with long descriptions extend into lower widgets.
- Fix: [OpenRCT2#21696] Fullscreen window option not correctly applied on macOS.
- Fix: [OpenRCT2#21749] Crash when loading park bigger than current limits.
- Fix: [OpenRCT2#21787] Map generator heightmap should respect increased height limits.
- Fix: [OpenRCT2#21829] When creating a new scenario, the default name contains formatting codes.
- Fix: [OpenRCT2#21937] Build errors with the ORIGINAL_RATINGS flag.
- Fix: [objects#324] Cannot build Colosseum inside a turn or helix.
- Fix: [objects#325] Sloped castle walls are vertically offset by one pixel (original bug).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants