Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOSX - Not remembering fullscreen window option, always opens in windowed mode after closing. #21696

Closed
dma1989 opened this issue Mar 31, 2024 · 2 comments
Labels
bug Something went wrong. macOS (OS) Related to the macOS version of OpenRCT2.

Comments

@dma1989
Copy link

dma1989 commented Mar 31, 2024

Operating System

OSX

OpenRCT2 build

OpenRCT2, v0.4.9 (a172405 on HEAD)

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

This is a development issue

Describe the issue

OSX app always opens in windowed mode.

Even if the 'fullscreen' or 'fullscreen (borderless window)' options are selected and then closed, it will always open in windowed mode when starting the game again.

Even going into the config.ini file when the game is closed and changing the "fullscreen_mode" property to 1 or 2 doesn't resolve the issue. It still opens in windowed mode because the game changes the property back to 0 when the game is opened.

Steps to reproduce

Option 1:

  • Open OpenRCT2 on Mac OSX
  • Select 'Options'
  • Change 'Screen mode' to either 'full screen' or 'fullscreen (borderless window)'
  • Close the game (either through the 'Exit' icon in the bottom right of the screen, or by pressing Cmd + Q)
  • Reopen the game
  • It will have reopened in windowed mode again

Option 2:

  • Ensure OpenRCT2 is closed
  • Open Finder and navigate to USERFOLDER > Library > Application Support > OpenRCT2
  • Open the config.ini file in TextEdit
  • The 'fullscreen_mode' property will be set to zero. (The text will appear as fullscreen_mode = 0)
  • Change this to fullscreen_mode = 1 for 'full screen' or fullscreen_mode = 2 for 'fullscreen (borderless window)'
  • Save config.ini and close TextEdit
  • Open OpenRCT2
  • It will have reopened in windowed mode again

Attachments

No response

@dma1989 dma1989 added the bug Something went wrong. label Mar 31, 2024
@Gymnasiast Gymnasiast added the macOS (OS) Related to the macOS version of OpenRCT2. label Apr 2, 2024
@ayvaak
Copy link
Contributor

ayvaak commented Apr 9, 2024

Working on this!

@ayvaak
Copy link
Contributor

ayvaak commented Apr 20, 2024

It looks like there's a bit of code in UIContext.cpp (starting on line 765) that's hard-coding Mac to open in windowed mode. Issue #4022 was a problem with the cursor, but removing the code saves the fullscreen preference and doesn't seem to cause any cursor bugs to happen anymore. MichaelJBerk also commented on Issue #4022 that the workaround doesn't seem to be necessary in November 2023.

Should I go ahead and remove this bit of code, and make a commit? I'll also ask about this in the Discord.

Screen Shot 2024-04-20 at 2 40 49 PM

ayvaak added a commit to ayvaak/OpenRCT2481Fixes that referenced this issue Apr 21, 2024
Removes an obsolete workaround to fix a problem with the program not saving your window settings on Mac. OpenRCT2#21696
ayvaak added a commit to ayvaak/OpenRCT2481Fixes that referenced this issue Apr 21, 2024
Removes an obsolete workaround to fix a problem with the program not saving your window settings on Mac. OpenRCT2#21696
ayvaak added a commit to ayvaak/OpenRCT2481Fixes that referenced this issue Apr 21, 2024
ayvaak added a commit to ayvaak/OpenRCT2481Fixes that referenced this issue Apr 23, 2024
ayvaak added a commit to ayvaak/OpenRCT2481Fixes that referenced this issue Apr 23, 2024
janisozaur added a commit that referenced this issue May 5, 2024
- Feature: [#11512] Coloured usernames by group on multiplayer servers.
- Feature: [#21734] Park admittance price can now be set via text input.
- Feature: [#21957] [Plugin] Expose whether the game is paused to the plugin API.
- Improved: [#21728] “Fix all rides” cheat now also works if a mechanic is already fixing the ride.
- Improved: [#21769] Expose “animation is backwards” wall property in Tile Inspector.
- Improved: [#21855] Add a separator between “Load Game” and “Save Game”, to avoid accidental overwriting.
- Change: [#21715] [Plugin] Remove access to the internal `owner` property. Note: `ownership` is still accessible.
- Change: [#21855] Cheats menu dropdown no longer requires dragging.
- Change: [#21866] Hide the FPS Counter when the top toolbar/widgets have been toggled off.
- Change: [#21950] Construction and removal buttons can now be held down for repeated placement.
- Fix: [#866] Boat Hire boats get stuck entering track (original bug).
- Fix: [#10701] No reason specified when placing door over unsuitable track.
- Fix: [#18723, #21870] Attempting to demolish a flat ride in pause mode allows you to place multiple copies.
- Fix: [#19559] Custom rides with long descriptions extend into lower widgets.
- Fix: [#21696] Fullscreen window option not correctly applied on macOS.
- Fix: [#21749] Crash when loading park bigger than current limits.
- Fix: [#21787] Map generator heightmap should respect increased height limits.
- Fix: [#21829] When creating a new scenario, the default name contains formatting codes.
- Fix: [#21937] Build errors with the ORIGINAL_RATINGS flag.
- Fix: [objects#324] Cannot build Colosseum inside a turn or helix.
- Fix: [objects#325] Sloped castle walls are vertically offset by one pixel (original bug).
mrmbernardi pushed a commit to mrmbernardi/OpenRCT2 that referenced this issue May 10, 2024
- Feature: [OpenRCT2#11512] Coloured usernames by group on multiplayer servers.
- Feature: [OpenRCT2#21734] Park admittance price can now be set via text input.
- Feature: [OpenRCT2#21957] [Plugin] Expose whether the game is paused to the plugin API.
- Improved: [OpenRCT2#21728] “Fix all rides” cheat now also works if a mechanic is already fixing the ride.
- Improved: [OpenRCT2#21769] Expose “animation is backwards” wall property in Tile Inspector.
- Improved: [OpenRCT2#21855] Add a separator between “Load Game” and “Save Game”, to avoid accidental overwriting.
- Change: [OpenRCT2#21715] [Plugin] Remove access to the internal `owner` property. Note: `ownership` is still accessible.
- Change: [OpenRCT2#21855] Cheats menu dropdown no longer requires dragging.
- Change: [OpenRCT2#21866] Hide the FPS Counter when the top toolbar/widgets have been toggled off.
- Change: [OpenRCT2#21950] Construction and removal buttons can now be held down for repeated placement.
- Fix: [OpenRCT2#866] Boat Hire boats get stuck entering track (original bug).
- Fix: [OpenRCT2#10701] No reason specified when placing door over unsuitable track.
- Fix: [OpenRCT2#18723, OpenRCT2#21870] Attempting to demolish a flat ride in pause mode allows you to place multiple copies.
- Fix: [OpenRCT2#19559] Custom rides with long descriptions extend into lower widgets.
- Fix: [OpenRCT2#21696] Fullscreen window option not correctly applied on macOS.
- Fix: [OpenRCT2#21749] Crash when loading park bigger than current limits.
- Fix: [OpenRCT2#21787] Map generator heightmap should respect increased height limits.
- Fix: [OpenRCT2#21829] When creating a new scenario, the default name contains formatting codes.
- Fix: [OpenRCT2#21937] Build errors with the ORIGINAL_RATINGS flag.
- Fix: [objects#324] Cannot build Colosseum inside a turn or helix.
- Fix: [objects#325] Sloped castle walls are vertically offset by one pixel (original bug).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong. macOS (OS) Related to the macOS version of OpenRCT2.
Projects
None yet
Development

No branches or pull requests

3 participants