Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve boat hire pathfinding #866

Closed
Krutonium opened this issue Feb 24, 2015 · 13 comments · Fixed by #21745
Closed

Improve boat hire pathfinding #866

Krutonium opened this issue Feb 24, 2015 · 13 comments · Fixed by #21745
Labels
original bug This was an issue in the original game already.

Comments

@Krutonium
Copy link
Member

scr1
Look at the Boat Hire (Center Screen) trying to get back in.

https://www.dropbox.com/s/4ch8b4tc7p8zxc8/Leafy%20Lake%20-%20Boathire.SV6?dl=1

@IntelOrca IntelOrca added the original bug This was an issue in the original game already. label Feb 24, 2015
@duncanspumpkin
Copy link
Contributor

Nope not possible yet. And i suggest changing the title to boat hire pathfinding so we can find it later.

@IntelOrca IntelOrca changed the title Can we fix this yet (Original Bug) Improve boat hire pathfinding Feb 24, 2015
@Gymnasiast
Copy link
Member

Another reported problem is boats getting stuck and doing nothing intelligent to get moving again:

stuck_boats

@duncanspumpkin
Copy link
Contributor

Copy paste of @bourne2program who posted in a closed issue:

Ugh really annoying. Should be simple to detect occurrence and solution can just be to move one inwards on track if none already there

image image image image

@superchadST345
Copy link

I did a test and built a boat hire with just a single boat and it seemed to work fine, 2 boats seemed to work fine, I would imagine that the issue happens when there are too many boats, ill do more testing and try with more and more boats to see what happens.

@bourne2program
Copy link

I did a test and built a boat hire with just a single boat and it seemed to work fine, 2 boats seemed to work fine, I would imagine that the issue happens when there are too many boats, ill do more testing and try with more and more boats to see what happens.

It only takes 2, then additional boats that come also get stuck. It's difficult to reproduce for the boats to arrive at around the same time to cause it, but it usually will occur sooner or later.

@superchadST345
Copy link

I ran on hyper speed with 2 boats with no issues in the time I tested, but with 3 boats issues occurred very quickly (I had 2 instances of the game running, one with 2, one with 3 boats)

I am wondering if there is a way to keep boats from being too close to other boats

@bourne2program
Copy link

I ran on hyper speed with 2 boats with no issues in the time I tested, but with 3 boats issues occurred very quickly (I had 2 instances of the game running, one with 2, one with 3 boats)

I am wondering if there is a way to keep boats from being too close to other boats

Just did it with 2 bumper boats. Try with access from both sides.

image

@ocalhoun6
Copy link
Contributor

I am wondering if there is a way to keep boats from being too close to other boats

That's probably a good idea in general, since it may also help resolve the issue of them getting stuck in other places with other boats blocking the way.

But, it would make the Bumper Boats never actually bump each other.

Maybe instead, collision detection between boats could be disabled if they're within 1 tile of any of their own track pieces? (Obviously, they still need to do collision detection for all non-boat objects, so they don't go wandering all over the map.)

@bourne2program
Copy link

I am wondering if there is a way to keep boats from being too close to other boats

I would caution against this alone, for currently in narrow and other specific water areas - congestion can already cause significant delays for boats ever returning.

But, it would make the Bumper Boats never actually bump each other.

Great point!
I was thinking maybe boats could search for a random short path to a nearby point and those tiles of the path are blockable to other boats (similar to how it would work in real life that you would avoid getting in front of someone's heading), though that would go against what you mentioned for the Bumper Boats

Maybe instead, collision detection between boats could be disabled if they're within 1 tile of any of their own track pieces?

Specifically their own track piece that is open to join (which I think with consecutive track requirement is at most 1 track piece per ride).

@ocalhoun6
Copy link
Contributor

Maybe instead, collision detection between boats could be disabled if they're within 1 tile of any of their own track pieces?

Specifically their own track piece that is open to join (which I think with consecutive track requirement is at most 1 track piece per ride).

Eh, I'd go for any track piece, because I have seen some of the larger boats (such as canoes) actually interfere with each other when one is on the track and one is not. Having a boat near the track can cause a boat on the track to stop. And the two boats can get jammed together when one is on the track and one is not.

(That's a bit of a separate issue, but it would be nice to solve both at once.)

@bourne2program
Copy link

I have seen some of the larger boats (such as canoes) actually interfere with each other when one is on the track and one is not

Oh I didn't know that was an issue. Thought it be strange to limit boats from going into tiles next to tracks. Could cause problems in narrow waterways.

@ocalhoun6
Copy link
Contributor

Not prevent them from going there entirely -- just disable boat/boat collision detection while they're in that area.

Come to think of it, there's another possible (hacky) solution here:

  • For every boat/boat collision anywhere, give it a small chance (like 1 in 20) of ignoring the collision and allowing the two boats to pass through each other. That way, 95% of boat collisions work as normal, so it won't be very noticeable during normal play, but that 5% chance of boats passing through each other means that no boat will ever get stuck against another boat for very long. As they try over and over again, within 20 attempts, they'll pass through the other boat and get un-stuck.

@MASHzj
Copy link

MASHzj commented Oct 2, 2023

Isn't the problem that causes this bug that boats stop for a moment when they enter the track? That is at least what I always observed. If at that moment another boat collides, they both get stuck. So maybe changing that behaviour of boats stopping could be a solution?

Gymnasiast added a commit that referenced this issue Apr 10, 2024
Fix #866: Boat Hire boats get stuck entering track
mattbilik pushed a commit to evmarcus/OpenRCT2 that referenced this issue Apr 15, 2024
xrgtmx added a commit to xrgtmx/OpenRCT2 that referenced this issue May 1, 2024
Gymnasiast pushed a commit that referenced this issue May 1, 2024
janisozaur added a commit that referenced this issue May 5, 2024
- Feature: [#11512] Coloured usernames by group on multiplayer servers.
- Feature: [#21734] Park admittance price can now be set via text input.
- Feature: [#21957] [Plugin] Expose whether the game is paused to the plugin API.
- Improved: [#21728] “Fix all rides” cheat now also works if a mechanic is already fixing the ride.
- Improved: [#21769] Expose “animation is backwards” wall property in Tile Inspector.
- Improved: [#21855] Add a separator between “Load Game” and “Save Game”, to avoid accidental overwriting.
- Change: [#21715] [Plugin] Remove access to the internal `owner` property. Note: `ownership` is still accessible.
- Change: [#21855] Cheats menu dropdown no longer requires dragging.
- Change: [#21866] Hide the FPS Counter when the top toolbar/widgets have been toggled off.
- Change: [#21950] Construction and removal buttons can now be held down for repeated placement.
- Fix: [#866] Boat Hire boats get stuck entering track (original bug).
- Fix: [#10701] No reason specified when placing door over unsuitable track.
- Fix: [#18723, #21870] Attempting to demolish a flat ride in pause mode allows you to place multiple copies.
- Fix: [#19559] Custom rides with long descriptions extend into lower widgets.
- Fix: [#21696] Fullscreen window option not correctly applied on macOS.
- Fix: [#21749] Crash when loading park bigger than current limits.
- Fix: [#21787] Map generator heightmap should respect increased height limits.
- Fix: [#21829] When creating a new scenario, the default name contains formatting codes.
- Fix: [#21937] Build errors with the ORIGINAL_RATINGS flag.
- Fix: [objects#324] Cannot build Colosseum inside a turn or helix.
- Fix: [objects#325] Sloped castle walls are vertically offset by one pixel (original bug).
mrmbernardi pushed a commit to mrmbernardi/OpenRCT2 that referenced this issue May 10, 2024
- Feature: [OpenRCT2#11512] Coloured usernames by group on multiplayer servers.
- Feature: [OpenRCT2#21734] Park admittance price can now be set via text input.
- Feature: [OpenRCT2#21957] [Plugin] Expose whether the game is paused to the plugin API.
- Improved: [OpenRCT2#21728] “Fix all rides” cheat now also works if a mechanic is already fixing the ride.
- Improved: [OpenRCT2#21769] Expose “animation is backwards” wall property in Tile Inspector.
- Improved: [OpenRCT2#21855] Add a separator between “Load Game” and “Save Game”, to avoid accidental overwriting.
- Change: [OpenRCT2#21715] [Plugin] Remove access to the internal `owner` property. Note: `ownership` is still accessible.
- Change: [OpenRCT2#21855] Cheats menu dropdown no longer requires dragging.
- Change: [OpenRCT2#21866] Hide the FPS Counter when the top toolbar/widgets have been toggled off.
- Change: [OpenRCT2#21950] Construction and removal buttons can now be held down for repeated placement.
- Fix: [OpenRCT2#866] Boat Hire boats get stuck entering track (original bug).
- Fix: [OpenRCT2#10701] No reason specified when placing door over unsuitable track.
- Fix: [OpenRCT2#18723, OpenRCT2#21870] Attempting to demolish a flat ride in pause mode allows you to place multiple copies.
- Fix: [OpenRCT2#19559] Custom rides with long descriptions extend into lower widgets.
- Fix: [OpenRCT2#21696] Fullscreen window option not correctly applied on macOS.
- Fix: [OpenRCT2#21749] Crash when loading park bigger than current limits.
- Fix: [OpenRCT2#21787] Map generator heightmap should respect increased height limits.
- Fix: [OpenRCT2#21829] When creating a new scenario, the default name contains formatting codes.
- Fix: [OpenRCT2#21937] Build errors with the ORIGINAL_RATINGS flag.
- Fix: [objects#324] Cannot build Colosseum inside a turn or helix.
- Fix: [objects#325] Sloped castle walls are vertically offset by one pixel (original bug).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
original bug This was an issue in the original game already.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants