Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize non 3d webpages from rendering canvas #10421

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Jun 20, 2024

Summary

  • migrates originEntity, viewerEntity and localFloorEntity from Engine to EngineState
  • ensures all systems that do work or create things only do so if the viewerEntity exists
  • opts in to engine canvas for routes that need it, rather than always

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@HexaField
Copy link
Member Author

@SYBIOTE the visual script tests have started failing and i don't know why, are you able to take a look at it?

@HexaField HexaField requested review from MichaelEstes, speigg and aditya-mitra and removed request for MichaelEstes, speigg and aditya-mitra June 21, 2024 02:04
@HexaField HexaField marked this pull request as ready for review June 21, 2024 02:04
@HexaField HexaField merged commit db09aee into dev Jun 25, 2024
28 checks passed
@HexaField HexaField deleted the IR-2746-Optimize-performance-of-webpages-when-not-rendering-3d-world branch June 25, 2024 22:17
MbfloydIR added a commit that referenced this pull request Jun 25, 2024
* dev:
  Optimize non 3d webpages from rendering canvas (#10421)
  case insensitive full string search for file browser (#10431)
  [IR-2091] studio: update ContextMenu (#10434)
  Exported EditorRouter for MT
  chore: Update project removal logic to ignore resources JSON (#10446)
  fix File container styling (#10435)
  IR-2726 Material Component Breakup (#10406)
  Update onSet to correctly read colors (#10443)
  Fix hookstate bugs (101, 102) in SelectInput (#10442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants