add note

packages/engine/src/visualscript/components/VisualScriptComponent.tsx

@@ -28,7 +28,7 @@ import matches, { Validator } from 'ts-matches'
 
 import { cleanStorageProviderURLs, parseStorageProviderURLs } from '@etherealengine/common/src/utils/parseSceneJSON'
 import { Entity } from '@etherealengine/ecs'
-import { defineComponent, setComponent, useComponent } from '@etherealengine/ecs/src/ComponentFunctions'
+import { defineComponent, hasComponent, setComponent, useComponent } from '@etherealengine/ecs/src/ComponentFunctions'
 import { useEntityContext } from '@etherealengine/ecs/src/EntityFunctions'
 import { useMutableState } from '@etherealengine/hyperflux'
 import { useAncestorWithComponent } from '@etherealengine/spatial/src/transform/components/EntityTree'
@@ -118,6 +118,7 @@ const LoadReactor = (props: { entity: Entity; gltfAncestor: Entity }) => {
  setComponent(props.entity, VisualScriptComponent, { run: true })
 
  return () => {
+ if (!hasComponent(props.entity, VisualScriptComponent)) return
  setComponent(props.entity, VisualScriptComponent, { run: false })
  }
  }, [loaded])

packages/visual-script/tests/visualScript.test.tsx

@@ -72,6 +72,7 @@ import vec2TestVisualScript from './assets/vec2-test-visual-script.json'
 import vec3TestVisualScript from './assets/vec3-test-visual-script.json'
 import vec4TestVisualScript from './assets/vec4-test-visual-script.json'
 
+/** @todo rewrite these tests without relying on logging */
 describe.skip('visual Script', () => {
  let consoleSpy: Sinon.SinonSpy
  let consoleErrorSpy: Sinon.SinonSpy // Spy on console.error