IR-2726 Material Component Breakup #10406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…realengine/etherealengine into universal-material-entities
…ealengine/etherealengine into material-component-breakup
dinomut1
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Screencast from 06-24-2024 10:24:31 AM.webm
This video shows two bugs I'm seeing.
- Material prototype selection doesn't differentiate between materials which are extensions of a certain material class. In this video, I'm trying to switch between the Lava material and the Standard material. The Lava material is an extension of the Standard material, and so the UI doesn't recognize that they're different, and the prototype selection is a no-op.
- This can be fixed by using the userData.type field "type":
- Changing a material prototype only modifies one instance of the material
- looks like materials are not being shared across entities. When the prototype is changed from Lava to Basic, only one of the lava materials in the scene actually changes -- the other remains as a lava material.
dinomut1
approved these changes
Jun 24, 2024
HexaField
approved these changes
Jun 25, 2024
MbfloydIR
added a commit
that referenced
this pull request
Jun 25, 2024
* dev: Optimize non 3d webpages from rendering canvas (#10421) case insensitive full string search for file browser (#10431) [IR-2091] studio: update ContextMenu (#10434) Exported EditorRouter for MT chore: Update project removal logic to ignore resources JSON (#10446) fix File container styling (#10435) IR-2726 Material Component Breakup (#10406) Update onSet to correctly read colors (#10443) Fix hookstate bugs (101, 102) in SelectInput (#10442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaks up the material component array into explicitly defined components
Subtasks Checklist
Breaking Changes
References
closes https://tsu.atlassian.net/browse/IR-2726
QA Steps
Switch to the material-component-breakup branch on the advanced materials repo, see also
https://github.com/theinfinitereality/eepro-advanced-materials/pull/35