Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR-2091] studio: update ContextMenu #10434

Merged
merged 7 commits into from
Jun 25, 2024
Merged

[IR-2091] studio: update ContextMenu #10434

merged 7 commits into from
Jun 25, 2024

Conversation

dtlehrer
Copy link
Contributor

@dtlehrer dtlehrer commented Jun 21, 2024

Summary

refactors ContextMenu to use anchorEvent instead of anchorEl, removing props that can be implied from anchorEvent

Subtasks Checklist

Breaking Changes

References

closes IR-2091

QA Steps

Copy link
Collaborator

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation! ✅

@aditya-mitra aditya-mitra added this pull request to the merge queue Jun 25, 2024
Merged via the queue into dev with commit c4d2b0a Jun 25, 2024
28 checks passed
@aditya-mitra aditya-mitra deleted the ir-2091 branch June 25, 2024 07:02
MbfloydIR added a commit that referenced this pull request Jun 25, 2024
* dev:
  Optimize non 3d webpages from rendering canvas (#10421)
  case insensitive full string search for file browser (#10431)
  [IR-2091] studio: update ContextMenu (#10434)
  Exported EditorRouter for MT
  chore: Update project removal logic to ignore resources JSON (#10446)
  fix File container styling (#10435)
  IR-2726 Material Component Breakup (#10406)
  Update onSet to correctly read colors (#10443)
  Fix hookstate bugs (101, 102) in SelectInput (#10442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants