MacOS #2
Merged
MacOS #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstructiveSolidGeometry.glsl and into BuiltinFunctions.glsl. This lets us avoid including all the Ray and CSG code just to do simple things like the depth plane. This is motivated by (driver?) problems on MacOS X 10.6 that cause it to choke in various interesting ways on the more complicated parts of Ray and CSG.
…onNew to avoid passing arrays without subscripts to constructors because I believe this is illegal. However, the change causes Firefox and Chrome stable to bomb on the shader so I'm reverting it for now, even though Chrome 19 beta, Chrome without ANGLE, and Firefox without ANGLE all think it's just great.
Conflicts: Source/Shaders/Ray.glsl
|
Can you take a quick look at making custom sensors work? The fragment shader is actually pretty simple. Chances are the shader concatenation in CustomSensorVolume.js is bringing in more shader code than it needs, e.g., ShadersConstructiveSolidGeometry. |
|
Yes, I'll do that next. Does it make sense to pull this into main first though, given that I may not look at the sensors until Monday? |
pjcozzi
added a commit
that referenced
this pull request
Apr 27, 2012
mramato
pushed a commit
to mramato/cesium
that referenced
this pull request
Aug 5, 2013
Style specs and minor tweaks.
hpinkos
pushed a commit
that referenced
this pull request
Sep 10, 2013
Clean up Viewer balloon usage
craigsketchley
pushed a commit
to craigsketchley/cesium
that referenced
this pull request
Aug 27, 2014
keattang
referenced
this pull request
in PropellerAero/cesium
Jul 22, 2015
Support an array of subdomains to prepend to tiles, for performance.
oterral
pushed a commit
to oterral/cesium
that referenced
this pull request
Oct 29, 2015
Remove parenthesis
pjcozzi
added a commit
that referenced
this pull request
Feb 1, 2017
3D Tiles Styling - Type Mismatches #2
hpinkos
pushed a commit
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the most significant problems with Cesium on Mac OS X 10.6 in Chrome. To my knowledge, everything works except sensor volumes.