Merge pull request #2 from CesiumGS/master

update fork

.appveyor.yml

@@ -13,8 +13,9 @@ install:
  - npm install
 
 test_script:
- - npm --silent run build
- - npm --silent run test -- --browsers IE --webgl-stub --suppressPassed
+ - npm --silent run minifyRelease
+ - npm --silent run build-specs
+ - npm --silent run test -- --browsers IE --webgl-stub --release --suppressPassed
 
 # Don't actually build.
 build: off

.concierge/templates/pullRequestOpened.hbs

@@ -1,7 +1,7 @@
 {{#if askAboutContributors}}
 Thank you so much for the pull request @{{ userName }}! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
 
-The [Pull Request Guidelines](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#pull-request-guidelines) is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
+The [Pull Request Guidelines](https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md#pull-request-guidelines) is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
 
 * :x: Missing `CONTRIBUTORS.md` entry.
  * Please add yourself to the [contributors]({{ contributorsUrl }}) file!
@@ -10,15 +10,15 @@ Thanks for the pull request @{{ userName }}!
 {{/if}}
 {{#if claEnabled}}
 {{#if errorCla}}
-* :grey_exclamation: There was an error checking the CLA! If this is your first contribution, please send in a [Contributor License Agreement](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla).
+* :grey_exclamation: There was an error checking the CLA! If this is your first contribution, please send in a [Contributor License Agreement](https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla).
  * Maintainers, this was the error I ran into while attempting to process the CLA check. Please resolve it to continue CLA checking.
  ```
  {{ errorCla }}
  ```
 {{else}}
 {{#if askForCla}}
 * :x: Missing CLA.
- * Please send in a [Contributor License Agreement](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla) (CLA) and comment back here to let us know to check this!
+ * Please send in a [Contributor License Agreement](https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla) (CLA) and comment back here to let us know to check this!
 {{else}}
 * :heavy_check_mark: Signed CLA found.
 {{/if}}
@@ -34,7 +34,7 @@ Thanks for the pull request @{{ userName }}!
 {{/if}}
 {{#if askAboutTests}}
 * :grey_question: Unit tests were not updated.
- * Make sure you've [updated tests](https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/TestingGuide) to reflect your changes, added tests for any new code, and ran the code coverage tool.
+ * Make sure you've [updated tests](https://github.com/CesiumGS/cesium/tree/master/Documentation/Contributors/TestingGuide) to reflect your changes, added tests for any new code, and ran the code coverage tool.
 {{/if}}
 
 Reviewers, don't forget to make sure that:

.editorconfig

@@ -3,13 +3,10 @@ root = true
 
 [*]
 indent_style = space
-indent_size = 4
+indent_size = 2
 charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
 [*.md]
 trim_trailing_whitespace = false
-
-[package.json]
-indent_size = 2

.eslintignore

@@ -2,11 +2,13 @@ Apps/HelloWorld.html
 Apps/Sandcastle/ThirdParty/**
 Build/**
 Documentation/**
-Instrumented/**
 Source/Shaders/**
 Source/ThirdParty/**
-Source/Workers/cesiumWorkerBootstrapper.js
+Source/Workers/**
+!Source/Workers/transferTypedArrayTest.js
 ThirdParty/**
 Tools/**
 Apps/Sandcastle/jsHintOptions.js
 Apps/Sandcastle/gallery/gallery-index.js
+Source/Core/buildModuleUrl.js
+Specs/spec-main.js

.eslintrc.json

@@ -1,9 +1,22 @@
 {
- "extends": "./Tools/eslint-config-cesium/browser.js",
+ "extends": ["./Tools/eslint-config-cesium/browser.js", "prettier"],
  "plugins": [
  "html"
  ],
  "rules": {
  "no-unused-vars": ["error", {"vars": "all", "args": "none"}]
- }
+ },
+ "overrides": [
+ {
+ "files": [
+ "index.cjs",
+ "server.cjs",
+ "gulpfile.js",
+ "Source/Workers/transferTypedArrayTest.js"
+ ],
+ "parserOptions": {
+ "sourceType": "script"
+ }
+ }
+ ]
 }

.github/ISSUE_TEMPLATE/bug_report.md

@@ -4,25 +4,25 @@ about: Let us know so we can fix it!
 ---
 
 <!--
-Thanks for helping us improve Cesium! Please describe what the expected behavior is vs what actually happens. 
+Thanks for helping us improve Cesium! Please describe what the expected behavior is vs what actually happens.
 
 Creating a Sandcastle example (https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/) that reproduces the issue helps us a lot in tracking down bugs. Paste the link you get from the "Share" button in Sandcastle below.
---> 
+-->
 
-Sandcastle example: 
+Sandcastle example:
 
 Browser:
 
 Operating System:
 
-<!-- 
+<!--
 
-If you can also contribute a fix, we'd absolutely appreciate it! Fixing a bug in Cesium often means fixing a bug for thousands of applications and millions of end users. 
+If you can also contribute a fix, we'd absolutely appreciate it! Fixing a bug in Cesium often means fixing a bug for thousands of applications and millions of end users.
 
-Check out the contributor guide to get started: 
+Check out the contributor guide to get started:
 
-https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md
+https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md
 
 Just let us know you're working on it and we'd be happy to provide advice and feedback.
 
--->
+-->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -3,12 +3,12 @@ name: Request a feature
 about: New ideas & improvements to Cesium are always welcome.
 ---
 
-<!-- 
-Thanks for helping make Cesium better! 
+<!--
+Thanks for helping make Cesium better!
 
-When suggesting an idea, give examples of the intended use case. Features that benefit the wider community are more likely to be prioritized. 
+When suggesting an idea, give examples of the intended use case. Features that benefit the wider community are more likely to be prioritized.
 
-The best way to get your ideas into Cesium is to help us! We love contributions and are always happy to be provide feedback and advice. Check out the contributor guide to get started: 
+The best way to get your ideas into Cesium is to help us! We love contributions and are always happy to be provide feedback and advice. Check out the contributor guide to get started:
 
-https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md
---> 
+https://github.com/CesiumGS/cesium/blob/master/CONTRIBUTING.md
+-->

.github/ISSUE_TEMPLATE/question.md

@@ -1,6 +1,6 @@
 ---
 name: Ask a question
-about: Please use the forum (https://groups.google.com/forum/#!forum/cesium-dev) for general questions about using Cesium. 
+about: Please use the community forum (https://community.cesium.com/) for general questions about using Cesium.
 ---
 
-:exclamation: Please use the [forum](https://groups.google.com/forum/#!forum/cesium-dev) for asking questions about how to use Cesium and best practices. The core Cesium team actively monitors the forum and we love seeing what people are working on! :exclamation:
+:exclamation: Please use the [community forum](https://community.cesium.com/) for asking questions about how to use Cesium and best practices. The core Cesium team actively monitors the forum and we love seeing what people are working on! :exclamation:

.gitignore

@@ -1,8 +1,8 @@
 /.metadata
 /Build
-/Instrumented
 /Cesium-*.zip
 /cesium-*.tgz
+.directory
 .DS_Store
 Thumbs.db
 .eslintcache
@@ -15,17 +15,18 @@ Thumbs.db
 
 /Source/Cesium.js
 
-/Source/Shaders/*.js
-/Source/Shaders/*/*.js
-/Source/Shaders/*/*/*.js
-/Source/ThirdParty/Shaders/*.js
-
 /Specs/SpecList.js
+/Source/Shaders/**/*.js
+/Source/ThirdParty/Shaders/**/*.js
+/Source/Workers/**
+!/Source/Workers/cesiumWorkerBootstrapper.js
+!/Source/Workers/transferTypedArrayTest.js
 
 /node_modules
 npm-debug.log
 npm-debug.log.*
 package-lock.json
+yarn.lock
 
 # WebStorm user-specific
 .idea/workspace.xml

.gulp.json

@@ -0,0 +1,5 @@
+{
+ "flags": {
+ "gulpfile": "gulpfile.cjs"
+ }
+}

.npmignore

@@ -11,20 +11,20 @@
 /.travis.yml
 /.vscode
 /Apps
+/Build/Apps
+/Build/Coverage
 /Build/minifyShaders.state
-/Build/Stubs
 /Build/Documentation
+/Build/Specs
 /Cesium-*.zip
 /Documentation
 /favicon.ico
 /gulpfile.js
 /index.html
 /index.release.html
-/Instrumented
 /launches
-/server.js
+/server.cjs
 /Source/copyrightHeader.js
-/Source/main.js
 /Specs
 /ThirdParty
 /Tools

.prettierignore

@@ -0,0 +1,29 @@
+
+# Ignore everything
+*
+
+# Unignore directories (to all depths) and unignore code and style files in these directories
+!.concierge/**/
+!.github/**/
+!.vscode/**/
+!Apps/**/
+!Documentation/**/
+!Source/**/
+!Specs/**/
+!Tools/**/
+
+!**/*.js
+!**/*.css
+!**/*.html
+!**/*.md
+
+# Re-ignore a few things caught above
+**/*.min.js
+Source/Cesium.js
+Source/Shaders/**/*.js
+Source/ThirdParty/**
+Source/Workers/**/*
+Apps/Sandcastle/ThirdParty
+
+!Source/Workers/cesiumWorkerBootstrapper.js
+!Source/Workers/transferTypedArrayTest.js

.slackbot.yml

@@ -1,15 +1,12 @@
+# List of Slack usernames (not GitHub) for the Cesium Concierge Slackbot to send release reminders for.
 releaseSchedule:
- ggetz: 2/1/2019
- hpinkos: 3/1/2019
- lilleyse: 4/1/2019
- tfili: 5/1/2019
- dbagnell: 6/3/2019
- tfili: 7/1/2019
- tfili: 8/1/2019
-
-greetings:
- - Happy Friday everyone!
- - Can you believe Friday is already here?
- - I hope you all had awesome week!
- - I skipped breakfast, so I hope Gary baked something good today...
- - Good morning everyone!
+ mamato: 3/2/2020
+ oshehata: 4/1/2020
+ lilleyse: 5/1/2020
+ ian: 6/1/2020
+ sam.suhag: 7/1/2020
+ sam.vargas: 8/3/2020
+ kevin: 9/1/2020
+ mamato: 10/1/2020
+ oshehata: 11/2/2020
+ lilleyse: 12/1/2020

.travis.yml

@@ -1,23 +1,19 @@
 language: node_js
 node_js:
- - "8"
-sudo: false
+ - "10"
 addons:
  chrome: stable
  firefox: latest
-before_script:
- - export DISPLAY=:99.0
- - sh -e /etc/init.d/xvfb start
 script:
  - npm --silent run deploy-set-version -- --buildVersion $TRAVIS_BRANCH.$TRAVIS_BUILD_NUMBER
  - npm --silent run deploy-status -- --status pending --message 'Waiting for build'
 
  - npm --silent run eslint
+ - npm --silent run prettier-check
 
  - npm --silent run build
- - npm --silent run test -- --browsers FirefoxHeadless --webgl-stub --failTaskOnError --suppressPassed
+ - npm --silent run coverage -- --browsers FirefoxHeadless --webgl-stub --failTaskOnError --suppressPassed
 
- - npm --silent run clean
  - travis_wait 20 npm --silent run makeZipFile -- --concurrency 1
  - npm pack &> /dev/null
 
@@ -26,11 +22,12 @@ script:
  - npm --silent run deploy-s3 -- -b cesium-dev -d cesium/$TRAVIS_BRANCH --confirm -c 'no-cache'
  - npm --silent run deploy-status -- --status success --message Deployed
 
- - npm --silent run test -- --browsers FirefoxHeadless --failTaskOnError --webgl-stub --release --suppressPassed
+ - npm --silent run build-specs
+ - npm --silent run test -- --browsers ChromeCI --failTaskOnError --webgl-stub --release --suppressPassed
 
-# Various Node.js smoke-screen tests
+ # Various Node.js smoke-screen tests
  - node -e "const Cesium = require('./');"
- - NODE_ENV=development node index.js
- - NODE_ENV=production node index.js
+ - NODE_ENV=development node index.cjs
+ - NODE_ENV=production node index.cjs
 
  - npm --silent run cloc

.vscode/launch.json

@@ -1,5 +1,5 @@
 {
- // Use IntelliSense to learn about possible Node.js debug attributes.
+ // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
@@ -8,14 +8,10 @@
  "type": "node",
  "request": "launch",
  "name": "Launch Program",
- "program": "${workspaceRoot}\\server.js",
- "cwd": "${workspaceRoot}"
- },
- {
- "type": "node",
- "request": "attach",
- "name": "Attach to Process",
- "port": 5858
+ "cwd": "${workspaceFolder}",
+ "runtimeExecutable": "npm",
+ "runtimeArgs": ["run-script", "start"],
+ "noDebug": true
  }
  ]
-}
+}

.vscode/settings.json

@@ -13,7 +13,6 @@
  },
  "search.exclude": {
  "Build": true,
- "Instrumented": true,
  "node_modules": true,
  "Source/Shaders/**/*.js": true
  },
@@ -23,7 +22,7 @@
  "files.trimTrailingWhitespace": true,
  "files.insertFinalNewline": true,
  "editor.insertSpaces": true,
- "editor.tabSize": 4,
+ "editor.tabSize": 2,
  "editor.detectIndentation": false,
  "eslint.enable": true,
  "javascript.format.insertSpaceAfterCommaDelimiter": true,

Apps/.jshintrc

@@ -21,7 +21,6 @@
  "boss": false,
  "debug": false,
  "eqnull": false,
- "esnext": false,
  "moz": false,
  "evil": false,
  "expr": false,