Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve containers types to use iterable objects #299
base: master
Are you sure you want to change the base?
Improve containers types to use iterable objects #299
Changes from all commits
fa22b81
c758bd4
096dc0f
66942d8
ecefc60
a06b5ca
21a7526
0e0d104
3a87f77
b0ae63a
b7b4690
f2832b7
fef57b1
a55146a
20bcdde
6ddc142
eb447ed
0e4059d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not need type-casting. Above check that $id is string.
Check warning on line 283 in src/Container.php
Check warning on line 310 in src/Container.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateMeta
always receive array. Not need iterable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better convert iterable to array before foreach
Check warning on line 506 in src/Container.php
Check warning on line 33 in src/ContainerConfig.php
Check warning on line 48 in src/ContainerConfig.php
Check warning on line 63 in src/ContainerConfig.php
Check warning on line 78 in src/ContainerConfig.php
Check warning on line 95 in src/ContainerConfig.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need fix phpdoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need fix phpdoc.