Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve containers types to use iterable objects #299

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Improve containers types to use iterable objects #299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fa22b81
Improve containers types to use iterable objects
xepozz Apr 19, 2022
c758bd4
Improve type checking
xepozz Apr 19, 2022
096dc0f
Fix tests
xepozz Apr 19, 2022
66942d8
Fix types notation
xepozz Apr 19, 2022
ecefc60
Fix test
xepozz Apr 19, 2022
a06b5ca
Fix text
xepozz Apr 20, 2022
21a7526
Merge branch 'master' into iterable
xepozz Dec 2, 2022
0e0d104
Fix tests
xepozz Dec 2, 2022
3a87f77
[ci-review] Apply changes from Rector action.
Dec 2, 2022
b0ae63a
Add support for iterable
xepozz Dec 2, 2022
b7b4690
Remove unused variable
xepozz Dec 2, 2022
f2832b7
Add test
xepozz Dec 2, 2022
fef57b1
Merge remote-tracking branch 'origin/iterable' into iterable
xepozz Dec 2, 2022
a55146a
Update src/ContainerConfigInterface.php
xepozz Dec 4, 2022
20bcdde
Merge branch 'master' into iterable
xepozz Jul 1, 2023
6ddc142
Add changelog
xepozz Jul 1, 2023
eb447ed
Change types in ServiceProviderInterface and classes
xepozz Jul 1, 2023
0e4059d
Update CHANGELOG.md
samdark Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix text
  • Loading branch information
@xepozz
xepozz committed Apr 20, 2022
commit a06b5ca8aea428d48069604e7a6466be437867c9
4 changes: 2 additions & 2 deletions src/Container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ private function validateDefinitionTags($tags): void
if (!is_iterable($tags)) {
throw new InvalidConfigException(
sprintf(
'Invalid definition: tags should be iterable object or array of strings, %s given.',
'Invalid definition: tags should be either iterable or array of strings, %s given.',
$this->getVariableType($tags)
)
);
Expand Down Expand Up @@ -414,7 +414,7 @@ private function setTags(iterable $tags): void
if (!is_iterable($services)) {
throw new InvalidConfigException(
sprintf(
'Invalid tags configuration: tag should be iterable object or array of service IDs, %s given.',
'Invalid tags configuration: tag should be either iterable or array of service IDs, %s given.',
$this->getVariableType($services)
)
);
Expand Down
4 changes: 2 additions & 2 deletions tests/Unit/ContainerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,7 +1795,7 @@ public function testNonArrayTags(): void

$this->expectException(InvalidConfigException::class);
$this->expectExceptionMessage(
'Invalid definition: tags should be iterable object or array of strings, integer given.'
'Invalid definition: tags should be either iterable or array of strings, integer given.'
);
new Container($config);
}
Expand All @@ -1808,7 +1808,7 @@ public function dataInvalidTags(): array
[42 => [EngineMarkTwo::class]],
],
[
'Invalid tags configuration: tag should be iterable object or array of service IDs, integer given.',
'Invalid tags configuration: tag should be either iterable or array of service IDs, integer given.',
['engine' => 42],
],
[
Expand Down