-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve containers types to use iterable objects #299
Open
xepozz
wants to merge
18
commits into
master
Choose a base branch
from
iterable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fa22b81
Improve containers types to use iterable objects
xepozz c758bd4
Improve type checking
xepozz 096dc0f
Fix tests
xepozz 66942d8
Fix types notation
xepozz ecefc60
Fix test
xepozz a06b5ca
Fix text
xepozz 21a7526
Merge branch 'master' into iterable
xepozz 0e0d104
Fix tests
xepozz 3a87f77
[ci-review] Apply changes from Rector action.
b0ae63a
Add support for iterable
xepozz b7b4690
Remove unused variable
xepozz f2832b7
Add test
xepozz fef57b1
Merge remote-tracking branch 'origin/iterable' into iterable
xepozz a55146a
Update src/ContainerConfigInterface.php
xepozz 20bcdde
Merge branch 'master' into iterable
xepozz 6ddc142
Add changelog
xepozz eb447ed
Change types in ServiceProviderInterface and classes
xepozz 0e4059d
Update CHANGELOG.md
samdark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix tests
- Loading branch information
commit 0e0d1045cf8419d988b58c73be4d6bfa5d255847
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does not look right. The problem here is
42
, right?