Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CMake logic and add -Wno-pointer-sign #196

Merged
merged 3 commits into from
Dec 8, 2018
Merged

Remove unused CMake logic and add -Wno-pointer-sign #196

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32a8ce5
Remove unused CMake logic and ad -Wno-pointer-sign.
no-more-secrets Dec 7, 2018
be6b77e
Remove one more bit of unused logic
no-more-secrets Dec 7, 2018
7263351
Add -W into list of warnings
no-more-secrets Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unused CMake logic and ad -Wno-pointer-sign. 
There were a series of statements in the CMake file having
to do with controlling warning flags (including adding -Wall)
however they were not actually applied to the CMAKE_C_FLAGS
and so were unused.

This commit deletes that logic (which, if enabled, would
introduce many new warnings, especially the -std=c99).  But,
it leaves the -Wno-pointer-sign to disable that particular
warning which occurs in many places.
  • Loading branch information
@no-more-secrets
no-more-secrets committed Dec 7, 2018
commit 32a8ce5fe5ef75853c07d7fe9131ad664a24d960
23 changes: 3 additions & 20 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,32 +158,15 @@ IF(ENABLE_URL_INCLUDE MATCHES "ON")
ENDIF(ENABLE_URL_INCLUDE MATCHES "ON")

SET(CMAKE_C_WARN_FLAGS "")
CHECK_C_COMPILER_FLAG(-Wall SUPPORT_WALL)
CHECK_C_COMPILER_FLAG(-W SUPPORT_W)
CHECK_C_COMPILER_FLAG(-Wno-unused-parameter SUPPORT_WPARAM)
CHECK_C_COMPILER_FLAG(-Wno-pointer-sign SUPPORT_WPOINTER_SIGN)
CHECK_C_COMPILER_FLAG(-Wstrict-prototypes SUPPORT_WSTRICT_PROTOTYPES)
IF(NOT "${CMAKE_C_COMPILER_ID}" MATCHES SunPro)
CHECK_C_COMPILER_FLAG("-std=c99" SUPPORT_STD_FLAG)
ENDIF(NOT "${CMAKE_C_COMPILER_ID}" MATCHES SunPro)
IF(SUPPORT_W)
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -W")
ENDIF(SUPPORT_W)
IF(SUPPORT_WALL)
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -Wall")
ENDIF(SUPPORT_WALL)
IF(SUPPORT_WPARAM)
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -Wno-unused-parameter")
ENDIF(SUPPORT_WPARAM)
IF(SUPPORT_WPOINTER_SIGN)
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -Wno-pointer-sign")
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -Wno-pointer-sign")
ENDIF(SUPPORT_WPOINTER_SIGN)
IF(SUPPORT_WSTRICT_PROTOTYPES)
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -Wstrict-prototypes")
ENDIF(SUPPORT_WSTRICT_PROTOTYPES)
IF(SUPPORT_STD_FLAG)
SET(CMAKE_C_WARN_FLAGS "${CMAKE_C_WARN_FLAGS} -std=c99")
ENDIF(SUPPORT_STD_FLAG)

SET( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${CMAKE_C_WARN_FLAGS}" )

IF(ENABLE_URL_SIGN MATCHES "ON")
IF(OPENSSL_FOUND)
Expand Down