Remove unused CMake logic and add -Wno-pointer-sign #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a series of statements in the CMake file having to do with controlling warning flags (including adding -Wall) however they were not actually applied to the CMAKE_C_FLAGS and so were unused. This commit deletes that logic (which, if enabled, would introduce many new warnings, especially the -std=c99). But, it leaves the -Wno-pointer-sign to disable that particular warning which occurs in many places.
|
It also disables |
|
I have added the -W into the list of warnings; but notice that, before these commits, the -W was not enabled at all, because the CMAKE_C_WARN_FLAGS variable was not being set into the CMAKE_C_FLAGS variable (that's why -Wall was in fact not set!) Let me know if you want more explanation. Thanks |
|
Good catch, thank you! I've copied that fragment from Rspamd in fact, but I forgot to set CFLAGS appropriately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a series of statements in the CMake file having
to do with controlling warning flags (including adding
-Wall)however they were not actually applied to the
CMAKE_C_FLAGSand so were unused.
This commit deletes that logic (which, if enabled, would
introduce many new warnings, especially the
-std=c99). But,it leaves the
-Wno-pointer-signto disable that particularwarning which occurs in many places.