Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CMake logic and add -Wno-pointer-sign #196

Merged
merged 3 commits into from
Dec 8, 2018
Merged

Remove unused CMake logic and add -Wno-pointer-sign #196

merged 3 commits into from
Dec 8, 2018

Commits on Dec 7, 2018

  1. Remove unused CMake logic and ad -Wno-pointer-sign. 

    There were a series of statements in the CMake file having
to do with controlling warning flags (including adding -Wall)
however they were not actually applied to the CMAKE_C_FLAGS
and so were unused.

This commit deletes that logic (which, if enabled, would
introduce many new warnings, especially the -std=c99).  But,
it leaves the -Wno-pointer-sign to disable that particular
warning which occurs in many places.
    @no-more-secrets
    no-more-secrets committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    32a8ce5 View commit details
    Browse the repository at this point in the history

  2. Remove one more bit of unused logic

    @no-more-secrets
    no-more-secrets committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    be6b77e View commit details
    Browse the repository at this point in the history

  3. Add -W into list of warnings

    @no-more-secrets
    no-more-secrets committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    7263351 View commit details
    Browse the repository at this point in the history