Implemented Primitive Domain Socket Support described in https://github.com/v2ray/Planning/issues/25 #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might have pulled from 2b67533 which have test failures. If this is the reason for test fail in this pr, I can add anther merge command to resolve this issue given the issue on master have resolved. |
xiaokangwang
commented
Apr 5, 2018
| newError("Cannot Accept socket from listener").Base(err).AtDebug().WriteToLog() | ||
| if err == lasterror { | ||
| errortolerance-- | ||
| if errortolerance == 0 { |
There was a problem hiding this comment.
Guard against too many open file error
There was a problem hiding this comment.
Please put this comment into source code.
xiaokangwang
commented
Apr 5, 2018
| return err | ||
| } | ||
|
|
||
| if isUnixDomainSocketFileSystemBased(ls.path) && !___DEBUG_IGNORE_FLOCK { |
There was a problem hiding this comment.
If the unix domain socket is filesystem based, an file lock must be used to claim the right for listening on respective file.
There was a problem hiding this comment.
There was a problem hiding this comment.
Please put this comment into source code.
xiocode
pushed a commit
to going/v2ray-core
that referenced
this pull request
Dec 28, 2021
* fix:observatory not supported by multi-json * Fix: observatory starts with empty config & fails to close (v2ray#957) * Update strategy_leastping.go (v2ray#1019) * add custom probe URL support for observatory * add custom probe interval for observer * apply coding style * Fix: observatory log & JSON config(v2ray#1211) Co-authored-by: ihotte <[email protected]> * Change default probe url from api.v2fly.org to www.google.com * Cherry-pick missing code from branch 'dev-advloadblancer-2' Co-authored-by: Shelikhoo <[email protected]> Co-authored-by: Loyalsoldier <[email protected]> Co-authored-by: fanyiguan <[email protected]> Co-authored-by: ihotte <[email protected]> Co-authored-by: ihotte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only basic support for stream unix domain socket is included.
Works:
Dial & Listen for stream unix domain socket.
Won't work: