Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Primitive Domain Socket Support described in https://github.com/v2ray/Planning/issues/25 #1019

Merged
merged 31 commits into from
Apr 9, 2018
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
71c3e81
Rebase: Add domainsocket receiver config
xiaokangwang Feb 12, 2018
d845b4c
Created listener file
xiaokangwang Oct 31, 2017
c3cdd90
fix and generate protobuf
xiaokangwang Oct 31, 2017
fdfa49d
modify golang package name
xiaokangwang Oct 31, 2017
5a7c49f
Added Generated error helper
xiaokangwang Nov 3, 2017
a6612a2
Regenerate Pb
xiaokangwang Nov 3, 2017
8fe5326
Added function Stub
xiaokangwang Nov 3, 2017
b9dddd0
Added Dialer stub
xiaokangwang Nov 22, 2017
7afd26a
Type switch for UnixReceiver
xiaokangwang Dec 28, 2017
7b51a56
Fix pb err
xiaokangwang Dec 28, 2017
7f34cbd
Add Generated Files
xiaokangwang Dec 28, 2017
5e0ed59
added function stub for UnixReceiverHandler Instancer
xiaokangwang Dec 28, 2017
91f32cc
Auto Gen
xiaokangwang Feb 12, 2018
43abfc9
Unix listeners(sync commit)
xiaokangwang Mar 11, 2018
8e5063d
(Sync Commit)
xiaokangwang Mar 16, 2018
3b1f0ae
finish transport listener
xiaokangwang Mar 18, 2018
3e05a35
finish UnixInboundHandler
xiaokangwang Mar 18, 2018
09bf78a
notify progressTraffic to quit
xiaokangwang Mar 18, 2018
a00c076
Pass unused data into Receiver
xiaokangwang Mar 28, 2018
b67cd22
Test and bug fix
xiaokangwang Mar 29, 2018
c51830b
Added UnixSenderConfig
xiaokangwang Apr 4, 2018
7e96581
Added integration
xiaokangwang Apr 4, 2018
176a5c0
generalize interface
xiaokangwang Apr 4, 2018
d08929a
finish up dial
xiaokangwang Apr 5, 2018
4e609c9
Added Test for dial
xiaokangwang Apr 5, 2018
8b881d7
Rename to prevent confusion
xiaokangwang Apr 5, 2018
12012cd
Testing and fixs
xiaokangwang Apr 5, 2018
c542c04
Merge branch 'master' of github.com:v2ray/v2ray-core into domainsocket
xiaokangwang Apr 5, 2018
8e1507a
Prevent unuseful test failure
xiaokangwang Apr 5, 2018
6d1faf5
Remove staging code
xiaokangwang Apr 5, 2018
00016e0
Add comment
xiaokangwang Apr 6, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
finish transport listener
  • Loading branch information
xiaokangwang committed Mar 18, 2018
commit 3b1f0ae300f9fed247d2192109afc930e763a1ea
153 changes: 144 additions & 9 deletions transport/internet/domainsocket/listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,53 +5,157 @@ import (
"net"
"os"
"syscall"
"time"

"v2ray.com/core/common/bitmask"
)

type Listener struct {
ln net.Listener
listenerChan <-chan net.Conn
listenerChan chan<- net.Conn
ctx context.Context
path string
lockfile os.File
lockfile *os.File
state bitmask.Byte
cancal func()
}

const (
STATE_UNDEFINED = 0
STATE_INITIALIZED = 1 << iota
STATE_LOWERUP = 1 << iota
STATE_UP = 1 << iota
STATE_TAINT = 1 << iota
)

func ListenDS(ctx context.Context, path string) (*Listener, error) {

vln := &Listener{path: path}
vln := &Listener{path: path, state: STATE_INITIALIZED, ctx: ctx}
return vln, nil
}

func (ls *Listener) Down() error {
err := ls.ln.Close()
if err != nil {
newError(err).AtDebug().WriteToLog()
var err error
if !ls.state.Has(STATE_LOWERUP | STATE_UP) {
err = newError(ls.state).Base(newError("Invalid State:Down"))
if ___DEBUG_PANIC_WHEN_ENCOUNTED_IMPOSSIBLE_ERROR {
panic(err)
}
return err
}
return err

ls.cancal()
closeerr := ls.ln.Close()
var lockerr error
if isUnixDomainSocketFileSystemBased(ls.path) {
lockerr = giveupLock(ls.lockfile)
}
if closeerr != nil && lockerr != nil {
if ___DEBUG_PANIC_WHEN_ERROR_UNPROPAGATEABLE {
panic(closeerr.Error() + lockerr.Error())
}
}

if closeerr != nil {
return newError("Cannot Close Unix domain socket listener").Base(closeerr)
}
if lockerr != nil {
return newError("Cannot release lock for Unix domain socket listener").Base(lockerr)
}
ls.state.Clear(STATE_LOWERUP | STATE_UP)
return nil
}

//Setup systen level Listener
//LowerUP Setup systen level Listener
func (ls *Listener) LowerUP() error {
var err error

if !ls.state.Has(STATE_INITIALIZED) || ls.state.Has(STATE_LOWERUP) {
err = newError(ls.state).Base(newError("Invalid State:LowerUP"))
if ___DEBUG_PANIC_WHEN_ENCOUNTED_IMPOSSIBLE_ERROR {
panic(err)
}
return err
}

if isUnixDomainSocketFileSystemBased(ls.path) && !___DEBUG_IGNORE_FLOCK {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the unix domain socket is filesystem based, an file lock must be used to claim the right for listening on respective file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this comment into source code.

ls.lockfile, err = acquireLock(ls.path + ".lock")
if err != nil {
newError(err).AtDebug().WriteToLog()
return newError("Unable to acquire lock for filesystem based unix domain socket").Base(err)
}
}

err = cleansePath(ls.path)
if err != nil {
return newError("Unable to cleanse path for the creation of unix domain socket").Base(err)
}

addr := new(net.UnixAddr)
addr.Name = ls.path
addr.Net = "unix"
li, err := net.ListenUnix("unix", addr)
ls.ln = li
if err != nil {
return newError("Unable to listen unix domain socket").Base(err)
}

ls.state.Set(STATE_LOWERUP)

return nil
}

func (ls *Listener) UP(listener chan<- net.Conn, allowkick bool) error {
var err error
if !ls.state.Has(STATE_INITIALIZED|STATE_LOWERUP) || (ls.state.Has(STATE_UP) && !allowkick) {
err = newError(ls.state).Base(newError("Invalid State:UP"))
if ___DEBUG_PANIC_WHEN_ENCOUNTED_IMPOSSIBLE_ERROR {
panic(err)
}
return err
}
ls.listenerChan = listener
if ls.state.Has(STATE_UP) {
cctx, cancel := context.WithCancel(ls.ctx)
ls.cancal = cancel
go ls.uploop(cctx)
}
return nil
}

func (ls *Listener) uploop(cctx context.Context) {
var lasterror error
errortolerance := 5
for {
if cctx.Err() != nil {
return
}
conn, err := ls.ln.Accept()

if err != nil {
newError("Cannot Accept socket from listener").Base(err).AtDebug().WriteToLog()
if err == lasterror {
errortolerance--
if errortolerance == 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guard against too many open file error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this comment into source code.

newError("unix domain socket melt down as the error is repeating").Base(err).AtError().WriteToLog()
ls.cancal()
}
newError("unix domain socket listener is throttling accept as the error is repeating").Base(err).AtError().WriteToLog()
time.Sleep(time.Second * 5)
}
lasterror = err
}

ls.listenerChan <- conn
}
}

func isUnixDomainSocketFileSystemBased(path string) bool {
//No Branching
return path[0] != 0
}

func AcquireLock(lockfilepath string) (*os.File, error) {
func acquireLock(lockfilepath string) (*os.File, error) {
f, err := os.Create(lockfilepath)
if err != nil {
newError(err).AtDebug().WriteToLog()
Expand All @@ -69,6 +173,37 @@ func AcquireLock(lockfilepath string) (*os.File, error) {
}
return nil, err
}
return nil, err
}

func giveupLock(locker *os.File) error {
err := syscall.Flock(int(locker.Fd()), syscall.LOCK_UN)
if err != nil {
closeerr := locker.Close()
if err != nil {
if ___DEBUG_PANIC_WHEN_ERROR_UNPROPAGATEABLE {
panic(closeerr)
}
newError(closeerr).AtDebug().WriteToLog()
}
newError(err).AtDebug().WriteToLog()
return err
}
closeerr := locker.Close()
if closeerr != nil {
newError(closeerr).AtDebug().WriteToLog()
return closeerr
}
return closeerr
}

func cleansePath(path string) error {
_, err := os.Stat(path)
if err == os.ErrNotExist {
return nil
}
err = os.Remove(path)
return err
}

//DEBUG CONSTS
Expand Down