Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Code quality analysis #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Oct 6, 2022

What does this PR do?

Implements code quality analysis. This allows you to d

Implements code quality analysis into the repository. This allows you to run composer check to check for errors. It now also auto-checks every PR with composer check to create failed test if a code formatting is not correct.

Lastly, this PR updates existing code to pass quality analysis tests - to have proper code quality.

Test Plan

  • Implement new tests

Related PRs and Issues

No related issue.

Link your issue here if there is some

Have you read the Contributing Guidelines on issues?

Yes! 👏

This was referenced Oct 10, 2022
Copy link

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm. wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants