Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔎 Add Code Analyzer To ‘utopia-php/system’ #4373

Closed
5 tasks
christyjacob4 opened this issue Oct 10, 2022 · 7 comments
Closed
5 tasks

🔎 Add Code Analyzer To ‘utopia-php/system’ #4373

christyjacob4 opened this issue Oct 10, 2022 · 7 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags!

Comments

@christyjacob4
Copy link
Member

💭 Introduction

Code analyzer is one of the most valuable tools in the open source world. It not only ensures every high quality of the code but also allows CI/CD to ensure this. A code analyzer can find a potential bug, unexpected null value, or type mismatch. Having a code analyzer set up should be a high priority for every project as it makes the project more stable and bug-proof.

Your task is to update our library utopia-php/system and implement a code analyzer. We would like to use PHPStan as our analyzer.

To make this task easy, we created a sample pull request showing what exactly needs to be done to implement the analyzer into the Utopia PHP library: utopia-php/ab#8

🎯 Requirements

  • Experience with GitHub Actions.
  • Experience with Composer.
  • Experience with PHP.

✅ Task Summary

Please configure PHPStan to max level (9). If that gives you too many problems that you cannot solve, please drop to level 8. If you have trouble with level 8 as well, let us know, and we can consider a lower level on some repositories.

If you have questions, need any help, or just want to hang out, make sure to join us on our Discord server.

Happy Appwriting!

@christyjacob4 christyjacob4 added good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! labels Oct 10, 2022
@devmike123
Copy link

Can you assign me this? @christyjacob4

@devmike123
Copy link

Can you assign me this? @christyjacob4

@Meldiron

@Meldiron
Copy link
Contributor

@devmike123 sure thing! 😎 thanks for your interest! 🙏 Happy hacking! 🎃

@devmike123
Copy link

@devmike123 sure thing! 😎 thanks for your interest! 🙏 Happy hacking! 🎃

@Meldiron can you review the pr?
utopia-php/system#19

@stnguyen90
Copy link
Contributor

@devmike123 Thanks for the PR! 🤯 Please give us some time to review it.

@devmike123
Copy link

@Meldiron pr ready for merge- utopia-php/system#22

@eldadfux
Copy link
Member

Thank you everyone for celebrating Hacktoberfest 22 with us! This issue will now be closed as we're getting ready to celebrate Hacktoberfest 23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants