Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔎 Add Code Analyzer To ‘utopia-php/analytics’ #4376

Closed
5 tasks
christyjacob4 opened this issue Oct 10, 2022 · 14 comments · May be fixed by utopia-php/analytics#28
Closed
5 tasks

🔎 Add Code Analyzer To ‘utopia-php/analytics’ #4376

christyjacob4 opened this issue Oct 10, 2022 · 14 comments · May be fixed by utopia-php/analytics#28
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags!

Comments

@christyjacob4
Copy link
Member

💭 Introduction

Code analyzer is one of the most valuable tools in the open source world. It not only ensures every high quality of the code but also allows CI/CD to ensure this. A code analyzer can find a potential bug, unexpected null value, or type mismatch. Having a code analyzer set up should be a high priority for every project as it makes the project more stable and bug-proof.

Your task is to update our library utopia-php/analytics and implement a code analyzer. We would like to use PHPStan as our analyzer.

To make this task easy, we created a sample pull request showing what exactly needs to be done to implement the analyzer into the Utopia PHP library: utopia-php/ab#8

🎯 Requirements

  • Experience with GitHub Actions.
  • Experience with Composer.
  • Experience with PHP.

✅ Task Summary

Please configure PHPStan to max level (9). If that gives you too many problems that you cannot solve, please drop to level 8. If you have trouble with level 8 as well, let us know, and we can consider a lower level on some repositories.

If you have questions, need any help, or just want to hang out, make sure to join us on our Discord server.

Happy Appwriting!

@christyjacob4 christyjacob4 added good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! labels Oct 10, 2022
@aaheli8
Copy link

aaheli8 commented Oct 11, 2022

Can I be assigned this issue

@Meldiron
Copy link
Contributor

@aaheli8 Please consider picking a different type of issue so other contributors can try this one.

@aaheli8
Copy link

aaheli8 commented Oct 11, 2022

@Meldiron Yes Sure.

@BabyElias
Copy link

BabyElias commented Oct 11, 2022

@Meldiron If this issue's available,I would love to work on it..

@stnguyen90
Copy link
Contributor

@BabyElias Thanks for your interest! You may work on this issue 🙏 Happy hacking! 🎃

@BabyElias
Copy link

Thanks! Will begin working on this right away.

@BabyElias
Copy link

Created a Pull Request for the issue. Do let me know if I have to implement the workflow and also correct the errors found in PHP Files.

@Meldiron
Copy link
Contributor

@BabyElias Yes please, correct all errors found by code analyzer.

@BabyElias
Copy link

@Meldiron The Analyser found almost 100 errors, I might need help correcting some of them as mentioned in the PR.

@stnguyen90 stnguyen90 linked a pull request Oct 13, 2022 that will close this issue
@stnguyen90
Copy link
Contributor

@BabyElias, if it's too difficult to correct, you can try lowering the level a little so it doesn't pick up as many problems.

@BabyElias
Copy link

BabyElias commented Oct 14, 2022

Okay.
Reduced level to 6 and made all corrections.

@BabyElias
Copy link

Hey! Please review my PR.

@Meldiron
Copy link
Contributor

@BabyElias thanks for the PR! 🤯 Please give us some time to review it.

@eldadfux
Copy link
Member

Thank you everyone for celebrating Hacktoberfest 22 with us! This issue will now be closed as we're getting ready to celebrate Hacktoberfest 23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants