Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca develop #96

Merged
merged 79 commits into from
May 5, 2020
Merged

Conversation

lisa-bengtsson
Copy link
Contributor

@lisa-bengtsson lisa-bengtsson commented Apr 2, 2020

Updates to cellular automata stochastic physics. Added new regression test. Added possibility to run global and sub-grid CA, updates to coupling to convection. This PR goes with updates in PR's fv3atm, ccpp/physics, stochastic physics.

Related PR:
NCAR ccpp/physics #418
noaa-psd/stochastic_physics #15
NOAA-EMC/fv3atm #87
#96

Copy link
Collaborator

@JongilHan66 JongilHan66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes associated with samfdeepcnv.f look ok.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 6585dd5 into ufs-community:develop May 5, 2020
christinaholtNOAA referenced this pull request in christinaholtNOAA/ufs-weather-model Sep 3, 2020
New capability to use git submodule info to checkout externals

By default, an external with no specified sub-externals configuration file will
have its submodules checked out according to the information in that repository's
.gitmodules file. This process is recursive.

To prevent submodules from being checked out, the external description for that
repository should be listed as "externals = none".

To use submodule URL, local path, and reference hash information for a
sub-external, replace the 'local_path', 'repo_url', and 'branch' 'hash' or 'tag'
keywords with "from_submodule = True".

User interface changes?: Yes
externals keyword can be "none" to prevent loading submodules.
from_submodule keyword can be used to replace external configuration information
with information from a repository's submodule configuration.

Fixes: NOAA-GSL#96

Testing:
test removed: none
unit tests: all pass
system tests: all pass, added TestSubrepoCheckout to test new functionality
manual testing: Tests with ESCOMP/MOM_interface (see below)

    Just run checkout_externals: no change
    Remove "externals = ../Externals_MOM.cfg" from Externals.cfg: All four submodules
    of MOM6 checked out
    Set "externals = none" in Externals.cfg: No submodules checked out (empty directories)
    Modify da_hooks external in Externals_MOM.cfg (see below): da_hooks is checked out with
    MOM6 .gitmodules configuration.

[pkg/MOM6_DA_hooks]
protocol = git
from_submodule = True
required = True
climbfuji pushed a commit to climbfuji/ufs-weather-model that referenced this pull request Aug 4, 2021
…_from_develop_20210721

Update gsl/develop from develop 20210721
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/ufs-weather-model that referenced this pull request Oct 22, 2021
Add 'netcdf' and 'grib2' to input 'source' options in regional IC/LBC routines
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Change LOWBC to LBC0 in XML template
mkavulich pushed a commit to mkavulich/ufs-weather-model that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants