Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ca develop #87

Merged
merged 42 commits into from
May 4, 2020
Merged

Ca develop #87

merged 42 commits into from
May 4, 2020

Conversation

lisa-bengtsson
Copy link
Contributor

@lisa-bengtsson lisa-bengtsson commented Mar 24, 2020 •
edited by junwang-noaa
Loading

Updates to cellular automata for deep convection. Some cleaning. Changes goes with updates in stochastic_physics and ccpp/physics repositories.

NCAR ccpp/physics #418
noaa-psd/stochastic_physics #15
#87
ufs-weather-model #96

@lisa-bengtsson
CA global updates
29a6319
@lisa-bengtsson
ca updates
4804cb2
@lisa-bengtsson
merge with develop
139012b
@lisa-bengtsson
latest CA updates, SGS and global
4e08c6c
@lisa-bengtsson
Further updates and cleaning
7702c32
@lisa-bengtsson
remove isppt - will insert in CCPP at later stage
ff79d94
@lisa-bengtsson
updates to call to convection scheme
11b2ac2
@lisa-bengtsson
corrected allocation of field if do_ca is false
f396536
@lisa-bengtsson
ccpp mods
79214ac
@lisa-bengtsson
ccpp mods
aae53e7
@lisa-bengtsson
ccpp mods
f30c5e0
@lisa-bengtsson
ccpp mods
b81f9cb
@lisa-bengtsson
minor cleanign
fb18fb4
@lisa-bengtsson
update ccpp to develop
5f18613
@lisa-bengtsson
merge with latest develop
b2e8b5f
@lisa-bengtsson
CCPP updates
b1305ea
@lisa-bengtsson
added nthresh as namelist variable
a74a20d
@lisa-bengtsson
merge with master
73e07d4
@lisa-bengtsson
Merge remote-tracking branch 'EMC/develop' into CA_develop
b423b47
@lisa-bengtsson
merge with develop
dc91211
@lisa-bengtsson
nthresh update
45df754
@lisa-bengtsson
merge with develop ccpp/framework
c344e7b
@lisa-bengtsson
pulling in updates in sumbodule atmos_cubed_sphere
3f4c85f
@lisa-bengtsson
merge with develop and ccpp master
8adc2c4
@lisa-bengtsson
fix conflict in merge with develop
698d993
@lisa-bengtsson
remove some variables not used anyomre
e33af15
@lisa-bengtsson
Updates to GFS_deug
d32e523
@lisa-bengtsson
introducing closure/trigger/entrainment switches for CA convection
e15d833
@lisa-bengtsson
merge with remote/upstream/master
9dda482
@lisa-bengtsson
merge with FV3/develop
226f83d
This was referenced Apr 29, 2020
Merged
Merged
@climbfuji
Copy link
Collaborator

Associated PRs:

NCAR/ccpp-physics#418
NOAA-PSL/stochastic_physics#15
#87
ufs-community/ufs-weather-model#96

@climbfuji climbfuji mentioned this pull request Apr 29, 2020
Merged
pjpegion
pjpegion approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@pjpegion pjpegion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@climbfuji
Copy link
Collaborator

These changes look ok to me. In a follow-up PR, you could move vfact_ca from Coupling to Model, because this data is static and does not depend on the grid columns as far as I can see. This would also allow you to implement my suggestion for moving the vfact_ca initialization code into GFS_stochastics_init. And it saves memory, because as part of Model vfact_ca is only allocated one time per MPI task, while it is allocated nblock number of times as part of Coupling.

@pjpegion pjpegion mentioned this pull request May 4, 2020
Merged
@DusanJovic-NOAA DusanJovic-NOAA merged commit e8fd6ee into NOAA-EMC:develop May 4, 2020
ShanSunNOAA pushed a commit to ShanSunNOAA/fv3atm that referenced this pull request May 3, 2021
@DomHeinzeller
Merge pull request NOAA-EMC#87 from climbfuji/move-all-gsd-chem-proce…
2b980f2 
…ss-modules

Move all GSD chemistry process modules from ccpp-physics to GOCART
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
@laurenchilutti
Merge pull request NOAA-EMC#87 from XiaqiongZhou-NOAA/202101
03a7ae7 
Fix compiling error for GNU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@pjpegion pjpegion pjpegion approved these changes

@JongilHan66 JongilHan66 JongilHan66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lisa-bengtsson @climbfuji @junwang-noaa @pjpegion @JongilHan66 @DusanJovic-NOAA