Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsl/develop from develop 20210721 #96

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Jul 21, 2021

Description

Update gsl/develop from develop as of 2021/07/21. All code has been reviewed and tested before it was merged into the authoritative repository.

Changes in this PR:

  • Associated changes for the fv3atm, ccpp-physics and stochastic_physics changes described in the associated PRs below
  • Update of several infrastructure and coupled model components
  • New application ATMAERO that uses GOCART chemistry as ESMF NUOPC component
  • Documentation, CI and regression test updates
  • Update of several modulefiles (i.e. environments), including compiler updates on Cheyenne

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Testing

Regression testing against existing baselines on Hera with Intel and GNU

Intel

The following tests fail with bit-for-bit mismatches as expected (see below), but they all run to completion. All other tests pass.

control_thompson
control_thompson_no_aero
control_thompson_no_aero_debug
control_thompson_debug
control_thompson_extdiag_debug
regional_control_debug
fv3_rap
fv3_hrrr
fv3_rrfs_v1alpha
fv3_rrfs_v1beta
fv3_gsd
regional_quilt_2threads
regional_control
regional_quilt_netcdf_parallel
regional_quilt
regional_quilt_hafs
fv3_rrfs_v1beta_debug
fv3_rrfs_v1alpha_debug
regional_quilt_RRTMGP
fv3_gsd_debug
fv3_gsd_diag_debug

rt_hera_intel_verify_against_existing.log
rt_hera_intel_verify_against_existing_fail_test.log

GNU

The following tests fail with bit-for-bit mismatches as expected (see below), but they all run to completion. All other tests pass.

fv3_rrfs_v1alpha_debug
fv3_rrfs_v1beta_debug
control_thompson_extdiag_debug
fv3_gsd_diag_debug
fv3_rrfs_v1alpha
fv3_rrfs_v1beta
fv3_gsd
regional_control_debug
control_thompson
control_thompson_no_aero_debug
control_thompson_no_aero
control_thompson_debug
fv3_gsd_debug

rt_hera_gnu_verify_against_existing.log
rt_hera_gnu_verify_against_existing_fail_test.log

Why do these tests fail? Three reasons:
(1) Updates to GF in gsl/develop from previous commit change results of all suites that use GF
(2) Updates to MYNN PBL in gsl/develop from previous commit change results of all suites that use MYNN PBL
(3) Bug fix for subcycling in Thompson MP changes results for all suites that use subcycling for Thompson MP

Regression testing on Hera with Intel and GNU using rt_ccpp_dev.conf (first create, then verify): all tests pass :-)

rt_ccpp_dev_hera_intel_create.log
rt_ccpp_dev_hera_intel_verify.log
rt_ccpp_dev_hera_gnu_create.log
rt_ccpp_dev_hera_gnu_verify.log

Dependencies

NOAA-GSL/stochastic_physics#8
NOAA-GSL/ccpp-framework#16
NOAA-GSL/ccpp-physics#100
NOAA-GSL/fv3atm#102
#96

DeniseWorthen and others added 19 commits June 4, 2021 16:58
…ate 35d scripts from P7a mini-release (ufs-community#610)


* Updates CICE and Icepack 
* Updates the ice_in_template for changes due to the time manager update
* Updates ice_in_template to remove many unused settings; sets tr_FY false
* Fixes unitialized AccumCnts in CMEPS and turns on coupled GNU tests in rt_gnu.conf
* Updates 35d scripts to adjust tasking and add in-line post
…#584) (ufs-community#623)


* make nems_frac the default CPLMODE
* make FRAC_GRID=true the default
* remove non-frac grid regression tests
* change wall clock for debugfrac. This test runs in less than ~5mins
* remove additional cpld_bmark and wave tests and their 35d versions
* reduce fhmax control_c384 to 12 hours
* add optional variables to turn on mushy thermo
…fs-community#600)

* Move IO related configuration from fv3_cap to write grid component
* Get cice6 ice albedo to FV3
ufs-community#632)

* Add missing modulefile ufs_hera.gnu_debug; bug fix in tests/compile.sh when checking for DEBUG=Y
* Thompson subcycling for develop
…ity#573)


* updates for WW3 UKMO fb_coupling_fields which adds two additional coupling fields and requires the ww3_multi.inp 
files to change
* add restart time for wave model to be FHMAX
* Update CICE for zlvs
ufs-community#589)

* Introduction of CA domain definition
* Read/Write and restart capability of CA
* Change namelist control parameter so that CA time and space scales are adjusted for various resolutions given the same CA namelist input
* Significant cleaning of old ideas
* Improved coupling to cumulus convection to be committed in coordination with this issue: NCAR/ccpp-physics#657
Add the hourly maximum precipitation rate in mm/hr for all microphysics schemes and will be used only by regional configurations.
1) Update with g2tmpl/1.10.0 and upp/10.0.8;
2) Update the UPP control files for GFS, RRFS HAFS and grib2 table.
3) Update ufs module for wcoss_cray with upp/10.0.8 and g2tmp2/1.10.0.
4) Update rt.conf to turn on regional_quilt and regional_has and regional_quilt_RRTMG on wcoss_cray.
- Add GOCART submodule pointing to UFS-Aerosols authoritative repository (https://github.com/GEOS-ESM/GOCART)
- Update CMake build system to:
   - Enable building GOCART as a subproject
   - Add new `ATMAERO` APP to configure and build the coupled FV3-GOCART system

Co-authored-by: Dom Heinzeller <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
… on gaea, orion and wcoss_dell_p3 (ufs-community#642)

* Eliminate computational instability in the datm_cdeps_mx025_cfsr test on Gaea, Orion and WCOSS_dell_p3.
* Use the latest develop branch of CDEPS.
* Reduce the forecast time to 12 hours for the "datm_cdeps_mx025_cfsr" and "datm_cdeps_mx025_gefs" tests, so that the two tests can be done within 30 minutes.
…-community#619)

* Update submodule pointer for fv3atm and ccpp-physics for adding extended diagnostic output from Thompson MP
* Add a new regression test that exercises this capability
* Add optional scaling to RRTMGP flux adjustment
* Bugfixes to several suite definition files (add missing calls to GFS_radiation_surface)
* Bring back the changes made in CMEPS by EMC which have been merged at ESCOMP
* Read the docs documentation update for build, regression test, and utest
* CI updates to include L127 control, cpld_debug, and to update ubuntu-hpc container libraries

Co-authored-by: denise.worthen <[email protected]>
Co-authored-by: Dustin Swales <[email protected]>
Co-authored-by: Eric Aligo <[email protected]>
Co-authored-by: Dom Heinzeller <[email protected]>
Co-authored-by: Dom Heinzeller <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
* removing ncld from .IN files in parm
* reinsatating original rt.conf
* adding module purge to compile.sh
* updating some .IN files to remove ncld
* fixing control_ras and some other fixes
… update compiler versions on Cheyenne (ufs-community#592)

Cumulus convection updates:
a) More strict convection trigger
b) Reduced entrainment rate below cloud base
c) Enhanced downdraft detrainments starting from 60mb above the ground surface
d) Reduced rain evaporation
e) Modification of cloud depth separating shallow convection from deep convection

PBL and surface layer updates:
a) Inclusion of wind shear effect reducing characteristic mixing length
b) Reduction of background diffusivity in the inversion layers as a function of surface roughness and green vegetation fraction
c) PBL updraft overshooting limited by bulk Richardson number-based-PBL depth
d) Inclusion of new canopy heat storage parameterization
e) Modification of thermal roughness calculation over land
f) Increase of momentum roughness length over sea
g) Inclusion of sea spray effect parameterization
…unity#654)

* Update fv3atm to use NUOPC semantic labels in fv3cap, and refactor ModelAdvance.
* Update NEMS. Removed NEMS grid component (no need to set PE_MEMBER01: in model_configure anymore)
* Cleanup CMakeLists.txt
…Update CICE cap & fix time manager (was PR#664) (ufs-community#639)


* remove un-needed configuration files from input directories
* remove unused suites for s2s compiles on intel and gnu
* update CICE for nuopc cap updates and time manager fix
* add eps_imesh variable and set non-default values for
1deg configurations
* implement new variable for CICE RUNTYPE
* remove run scripts which are not used in any test
* update data_tables as required for merra2 output
* add inputs for ugwp and merra2 to cpld_bmark_tiled_run
* add readthedocs yaml config file, add custom.css file and
fix conf.py
* replace un-used test cpld_bmark_wave_v16_noahmp_nsst with
cpld_bmark_wave_v16_p7b from release/P7b branch
* removes use_frac_grid_input as test setup option
* add new test for p7b using noahmp,nsst,merra2,ugwd
* change DT_ATMOS to 300s in all bmark_v16 tests
* add suite for 7b test and modify rt_35 for 7b
* Change the timestep for the fv3_gsd and fv3_gsd_debug tests. Parallels use this new timestep to avoid crashes
* Per-timestep surface pressure diagnostics, similar to WRF
* Diagnostic 3D tendencies for all tracers
* There are two new tests: control_diag_debug and fv3_gsd_debug
@climbfuji climbfuji marked this pull request as ready for review July 22, 2021 02:16
@DomHeinzeller DomHeinzeller merged commit 7e31e44 into NOAA-GSL:gsl/develop Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet