Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AQM updates #1383

Closed
Closed

Conversation

rmontuoro
Copy link
Collaborator

@rmontuoro rmontuoro commented Aug 24, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR introduces the following updates relevant to the coupled UFS-AQM configuration (Online-CMAQ):

  • Rectify CCPP formulation of surface net heat fluxes provided to the coupled AQM component
  • Update AQM component to restore link to the EPA authoritative CMAQ repository
  • Use proper number of non-advected tracers and convective scavenging coefficients in regional_atmaq regression test

These updates will change the baseline for regional_atmaq.

Issue(s) addressed

Testing

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@BrianCurtis-NOAA
Copy link
Collaborator

What we prefer for making changes to authoritative repos (in this case AQM), is for PR's to be made from personal forks of authoritative repos and not branches created in authoritative repos. Please keep this in mind for future PR's. We can use your AQM branch bugfix/restore-epa-cmaq this time.

Also in .gitmodules we like to have the AQM section point to the repo/branch you're working on. Please make that change to .gitmodules, as we will revert it prior to merging at the end.

@BrianCurtis-NOAA
Copy link
Collaborator

I was able to test this on Orion and everything passed except atmaq, which is what was expected.

FAILED TESTS: 
+ echo 'FAILED TESTS: '
+ read -r failed_test_name
+ echo 'Test regional_atmaq 150 failed in check_result failed '
Test regional_atmaq 150 failed in check_result failed 
+ echo 'Test regional_atmaq 150 failed in check_result failed '
+ read -r failed_test_name
+ echo 'Test regional_atmaq 150 failed in run_test failed '
Test regional_atmaq 150 failed in run_test failed 
+ echo 'Test regional_atmaq 150 failed in run_test failed '
+ read -r failed_test_name
+ echo

jkbk2004 pushed a commit that referenced this pull request Sep 9, 2022
* acorn and common .lua changes, hera.intel (not hera.gnu) .lua changes

* CMake_Platform --> CMAKE_Platform

* jet and wcoss2 .lua changes, cheyenne.gnu/intel lua updates, orion lua updates, typo in jet.lua files, Orion fixes for .lua files

* Set proper number of non-advected tracers in regional_atmaq regression test.

* Add proper convective scavenging coefficients to the regional_ataqm regression test.

* Update ufs_s4.intel.lua, Update ufs_s4.intel_debug.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants