Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AQM updates (Was #1383) + Update to use .lua modulefiles (#1376) #1399

Merged

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Sep 6, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR introduces the following updates relevant to the coupled UFS-AQM configuration (Online-CMAQ):

  • Rectify CCPP formulation of surface net heat fluxes provided to the coupled AQM component
  • Update AQM component to restore link to the EPA authoritative CMAQ repository
  • Use proper number of non-advected tracers and convective scavenging coefficients in regional_atmaq regression test

These updates will change the baseline for regional_atmaq.

Issue(s) addressed

Testing

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

BrianCurtis-NOAA and others added 30 commits August 12, 2022 14:57
Convert S4 modulefiles to Lua
@BrianCurtis-NOAA BrianCurtis-NOAA changed the title AQM updates (Was #1383) AQM updates (Was #1383) + Update to use .lua modulefiles (#1376) Sep 6, 2022
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 6, 2022

/scratch2/NCEPDEV/marine/Jong.Kim/UFS-RT/rt-1399-intel/modulefiles/ufs_common.lua:
[string "help([[..."]:5: malformed number near '2.0.25'

@BrianCurtis-NOAA
Copy link
Collaborator Author

/scratch2/NCEPDEV/marine/Jong.Kim/UFS-RT/rt-1399-intel/modulefiles/ufs_common.lua: [string "help([[..."]:5: malformed number near '2.0.25'
Thanks, fixed.

@BrianCurtis-NOAA
Copy link
Collaborator Author

On orion, only the AQM test fails as planned.

@jkbk2004 jkbk2004 mentioned this pull request Sep 9, 2022
16 tasks
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 9, 2022

@BrianCurtis-NOAA all sounds good. Let go ahead to merge in dependencies. I am moving to ccpp.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 9, 2022

@BrianCurtis-NOAA fv3 pr merged in. Once pointers are updated here, we can merge in.

@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 done.

@jkbk2004 jkbk2004 merged commit 3c3548d into ufs-community:develop Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants