Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug related to sensible/latent heat fluxes for AQM coupling #1373

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Aug 17, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR fixed the bug described in NCAR/ccpp-physics issue#945.
The PR will not change the RTs.
Note that the crash was not triggered by the current domain settings in RT regional_atmaq. However, if the domain is larger and covers some sea ice areas, the crash will be triggered without this bug fix.

Issue(s) addressed

  • fixes NCAR/ccpp-physics/issues/<945>

Testing

A full RT was done on Hera.intel.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

  • waiting on NCAR/ccpp-physics/pull/<951>
  • waiting on noaa-emc/fv3atm/pull/<573>

…n FV3/ccpp/physics/physics/GFS_PBL_generic_post.F90
@ChunxiZhang-NOAA
Copy link
Contributor Author

Close this PR in favor of PR#1383

@ChunxiZhang-NOAA ChunxiZhang-NOAA deleted the bugfix/aqmflux branch September 9, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant