Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate vector unit #1928

Merged
merged 14 commits into from
Aug 6, 2024
Merged

Integrate vector unit #1928

merged 14 commits into from
Aug 6, 2024

Conversation

jerryz123
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 force-pushed the vector-release branch 8 times, most recently from 678df64 to c7aa223 Compare July 30, 2024 23:03
@jerryz123 jerryz123 force-pushed the vector-release branch 7 times, most recently from f427414 to 82b545d Compare August 6, 2024 04:08
@jerryz123 jerryz123 changed the title [WIP] Test integration of vector unit Integrate vector unit Aug 6, 2024
dpgrubb13
dpgrubb13 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@dpgrubb13 dpgrubb13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the few comment nits, LGTM.

@jerryz123 jerryz123 merged commit 5929221 into main Aug 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgrubb13 dpgrubb13 dpgrubb13 approved these changes

@abejgonzalez abejgonzalez Awaiting requested review from abejgonzalez

Assignees
No one assigned
Labels
changelog:added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @dpgrubb13