Do not extend from ObjectSet #68

johanjanssens · 2016-04-28T01:26:18Z

Do not extend ModelEntityComposite and DatabaseRowsetAbstract from ObjectSet, instead compose the objectset as private class property.

Breaking changes:

If you are extending from ObjectSet you can no longer access the 'data' property. To migrate your code use the API instead.
ModelEntityComposite::toArray() no longer flattens the whole entity collection it only returns a array representation of the current entity. To migrate your code, use iterator_to_array if you want to get a array representation of the all entities in the collection, or traverse through the collection.
DatabaseRowsetAbstract::toArray() no longer flattens the whole entity collection it only returns a array representation of the current entity. To migrate your code, use iterator_to_array if you want to get a array representation of the all entities in the collection, or traverse through the collection.
Both ModelEntityComposite and DatabaseRowsetAbstract no longer have an top() method. To migrate your code remove the top() method. The composable pattern will ensure that you always get the current entity returned.

- Add clear() method to clear the set - Use iterator_to_array in the toArray() method - Add filter() method to handle filtering of the set using a callable - Make the 'data' property private BREAKING! If you are extending from ObjectSet you can no longer access the 'data' property. To migrate your code use the API instead.

- Do not extend from ObjectSet, compose it - Implement missing interface methods - Refactor implemetation of filter() method - Change toArray() to return the current entity in the set BREAKING! ModelEntityComposite::toArray() no longer flattens the whole entity collection it only returns a array representation of the current entity. To migrate your code, use iterator_to_array if you want to get a array representation of the all entities in the collection, or traverse through the collection.

- Do not extend from ObjectSet, compose it - Implement missing interface methods - Refactor implemetation of filter() method - Change toArray() to return the current entity in the set BREAKING! DatabaseRowsetAbstract::toArray() no longer flattens the whole entity collection it only returns a array representation of the current entity. To migrate your code, use iterator_to_array if you want to get a array representation of the all entities in the collection, or traverse through the collection.

See: timble/kodekit#68

johanjanssens added the breaking label Apr 28, 2016

johanjanssens added this to the 3.0.0-beta.2 milestone Apr 28, 2016

johanjanssens added the refactor label Apr 28, 2016

johanjanssens added a commit that referenced this issue Apr 28, 2016

Issue #68: ModelEntity::top() method no longer exists

f548db9

johanjanssens mentioned this issue Apr 28, 2016

Do not extend from ObjectSet #69

Merged

johanjanssens added a commit that referenced this issue May 2, 2016

Issue #68: Remove objects instead of clearing and re-adding

b3437e2

johanjanssens closed this as completed in #69 May 3, 2016

johanjanssens added a commit to timble/kodekit-platform that referenced this issue May 3, 2016

Sync with changes in framework

9da6f38

See: timble/kodekit#68

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not extend from ObjectSet #68

Do not extend from ObjectSet #68

johanjanssens commented Apr 28, 2016 •

edited

Loading

Do not extend from ObjectSet #68

Do not extend from ObjectSet #68

Comments

johanjanssens commented Apr 28, 2016 • edited Loading

johanjanssens commented Apr 28, 2016 •

edited

Loading