Issue #68: Remove objects instead of clearing and re-adding

timble · May 2, 2016 · b3437e2 · b3437e2
1 parent 652c9c1
commit b3437e2
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/code/object/set.php b/code/object/set.php
@@ -105,12 +105,10 @@ public function merge(ObjectSet $set)
  public function filter(/*Callable*/ $filter)
  {
  $result = clone $this;
- $result->clear();
-
  foreach ($this as $object)
  {
- if (call_user_func($filter, $object) !== false) {
- $result->insert($object);
+ if (call_user_func($filter, $object) === false) {
+ $result->remove($object);
  }
  }