This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Do not extend from ObjectSet #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add clear() method to clear the set - Use iterator_to_array in the toArray() method - Add filter() method to handle filtering of the set using a callable - Make the 'data' property private BREAKING! If you are extending from ObjectSet you can no longer access the 'data' property. To migrate your code use the API instead.
- Do not extend from ObjectSet, compose it - Implement missing interface methods - Refactor implemetation of filter() method - Change toArray() to return the current entity in the set BREAKING! ModelEntityComposite::toArray() no longer flattens the whole entity collection it only returns a array representation of the current entity. To migrate your code, use iterator_to_array if you want to get a array representation of the all entities in the collection, or traverse through the collection.
- Do not extend from ObjectSet, compose it - Implement missing interface methods - Refactor implemetation of filter() method - Change toArray() to return the current entity in the set BREAKING! DatabaseRowsetAbstract::toArray() no longer flattens the whole entity collection it only returns a array representation of the current entity. To migrate your code, use iterator_to_array if you want to get a array representation of the all entities in the collection, or traverse through the collection.
|
@ercanozkaya Can you review, especially changes here: f548db9 |
| foreach ($this as $key => $row) { | ||
| $result[$key] = $row->toArray(); | ||
| if($row = $this->getIterator()->current()) { | ||
| $result = $row->toArray(); | ||
| } |
There was a problem hiding this comment.
@johanjanssens this is only returning a single row now.
There was a problem hiding this comment.
That is correct, this is an intended behavior change of the method.
Conflicts: code/view/json.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #68