Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set packageManager on app creation #1561

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

Nsttt
Copy link
Contributor

@Nsttt Nsttt commented Sep 11, 2023

Closes #1538

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Add packageManager field in package.json at app creation. Based on the package manager used.

Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: 860514a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 8:17am

@vercel
Copy link

vercel bot commented Sep 11, 2023

@Nsttt is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

cli/src/index.ts Outdated Show resolved Hide resolved
@juliusmarminge juliusmarminge added this pull request to the merge queue Sep 12, 2023
Merged via the queue into t3-oss:next with commit b8507dc Sep 12, 2023
42 of 43 checks passed
juliusmarminge pushed a commit that referenced this pull request Sep 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.


# Releases
## [email protected]

### Patch Changes

-   [#1561](#1561) [`b8507dc`](b8507dc) Thanks [@Nsttt](https://github.com/Nsttt)! - Add packageManager field in package.json at app creation
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.


# Releases
## [email protected]

### Patch Changes

-   [t3-oss#1561](t3-oss#1561) [`b8507dc`](t3-oss@b8507dc) Thanks [@Nsttt](https://github.com/Nsttt)! - Add packageManager field in package.json at app creation
realparadise added a commit to realparadise/create-t3-app that referenced this pull request Jun 12, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.


# Releases
## [email protected]

### Patch Changes

-   [#1561](t3-oss/create-t3-app#1561) [`b8507dc`](t3-oss/create-t3-app@b8507dc) Thanks [@Nsttt](https://github.com/Nsttt)! - Add packageManager field in package.json at app creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: set pkgJson.packageManager on init?
2 participants