Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set packageManager on app creation #1561

Merged
merged 6 commits into from
Sep 12, 2023
Merged

feat: set packageManager on app creation #1561

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31e5c26
feat: set packageManager on app creation
Nsttt Sep 11, 2023
4dabe47
feat: add missing trim in stdout
Nsttt Sep 11, 2023
3eb5989
chore: add changeset
Nsttt Sep 11, 2023
76870fe
chore: format imports
Nsttt Sep 11, 2023
4ee8a0b
feat: do not add packageManager in case of bun
Nsttt Sep 12, 2023
860514a
Merge branch 'next' into add-packageManager
juliusmarminge Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: set packageManager on app creation
  • Loading branch information
@Nsttt
Nsttt committed Sep 11, 2023
commit 31e5c263b758307720eb68cf4e7dd0c28c247dc3
9 changes: 9 additions & 0 deletions cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import {
getNpmVersion,
renderVersionWarning,
} from "./utils/renderVersionWarning.js";
import { getUserPkgManager } from "~/utils/getUserPkgManager.js";
import { execa } from "execa";

type CT3APackageJSON = PackageJson & {
ct3aMetadata?: {
Expand All @@ -27,6 +29,7 @@ type CT3APackageJSON = PackageJson & {

const main = async () => {
const npmVersion = await getNpmVersion();
const pkgManager = getUserPkgManager();
renderTitle();
npmVersion && renderVersionWarning(npmVersion);

Expand Down Expand Up @@ -55,6 +58,12 @@ const main = async () => {
) as CT3APackageJSON;
pkgJson.name = scopedAppName;
pkgJson.ct3aMetadata = { initVersion: getVersion() };

const { stdout } = await execa(pkgManager, ["-v"], {
cwd: projectDir,
});
pkgJson.packageManager = `${pkgManager}@${stdout}`;

fs.writeJSONSync(path.join(projectDir, "package.json"), pkgJson, {
spaces: 2,
});
Expand Down
Loading