Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set pkgJson.packageManager on init? #1538

Closed
juliusmarminge opened this issue Aug 14, 2023 · 3 comments · Fixed by #1561
Closed

feat: set pkgJson.packageManager on init? #1538

juliusmarminge opened this issue Aug 14, 2023 · 3 comments · Fixed by #1561
Labels
🌟 enhancement New feature or request 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR

Comments

@juliusmarminge
Copy link
Member

Is your feature request related to a problem? Please describe.

the packageManager field in package.json is used by things like corepack and github actions. it's very annoying when that field isn't set

Describe the solution you'd like to see

automatically add the field on project init. probably use the current version of the package manager that the user is using (simple parse on npm -v, pnpm -v or yarn -v depending on the user agent)

Describe alternate solutions

not doing it, shifting the responsibility to the user

Additional information

No response

@juliusmarminge juliusmarminge added the 🌟 enhancement New feature or request label Aug 14, 2023
@c-ehrlich
Copy link
Member

sounds good, open to PRs on this

@c-ehrlich c-ehrlich added the 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR label Aug 18, 2023
xonx4l added a commit to xonx4l/create-t3-app that referenced this issue Aug 19, 2023
@xonx4l
Copy link

xonx4l commented Aug 19, 2023

Waiting for your thoughts on this @juliusmarminge .

@juliusmarminge
Copy link
Member Author

Submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request 👨‍👦‍👦free for all Anyone is free to take on this issue and file a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants