Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add import order sorting via prettier #1392

Merged
merged 26 commits into from
May 17, 2023
Merged

feat: add import order sorting via prettier #1392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b0f3b8b
added import order sorting
FinnDore Apr 29, 2023
d816992
cli format
FinnDore Apr 29, 2023
1149c08
format www
FinnDore Apr 29, 2023
882177e
.
FinnDore May 5, 2023
760614a
done?
FinnDore May 5, 2023
d955bc2
lint
FinnDore May 5, 2023
28ced02
we do a little reverse
FinnDore May 7, 2023
ff5643f
fixed format:check writing
FinnDore May 7, 2023
75f09f9
smoll changes
FinnDore May 8, 2023
8fbb67d
Merge commit '1e4c2d352e9b42e0f48c98980714c5334bfd06d7' into prettier…
FinnDore May 9, 2023
68bd141
split out installers
FinnDore May 9, 2023
4ee772f
removed eslint from base project
FinnDore May 9, 2023
01de8cd
added eslint back
FinnDore May 9, 2023
aa79698
formatting
FinnDore May 9, 2023
c14ca2a
fixed linting
FinnDore May 9, 2023
86d07ed
fixed base project
FinnDore May 9, 2023
d37d813
rip ci time
FinnDore May 9, 2023
f0b4089
Update cli/template/extras/config/_prettier.config.cjs
juliusmarminge May 13, 2023
a665f39
need to test this but.
FinnDore May 13, 2023
976d21d
Merge branch 'prettier-import-order' of https://github.com/FinnDore/c…
FinnDore May 13, 2023
db03947
removed uneeded resolve
FinnDore May 13, 2023
63fad92
docs update
FinnDore May 14, 2023
02b64de
Moved over to a seperate prompt
FinnDore May 16, 2023
7e77640
yuh
FinnDore May 16, 2023
f16ce44
spelling
FinnDore May 16, 2023
ab01b4d
this?
FinnDore May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed format:check writing
  • Loading branch information
@FinnDore
FinnDore committed May 7, 2023
commit ff5643f888820905694176f71cc8a1423da80bc3
4 changes: 2 additions & 2 deletions cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"start": "node dist/index.js",
"lint": "eslint . --report-unused-disable-directives",
"lint:fix": "pnpm lint --fix",
"format": "prettier --write --plugin-search-dir=. **/*.{cjs,mjs,ts,tsx,md,json} --ignore-path ../.gitignore --ignore-unknown --no-error-on-unmatched-pattern",
"format:check": "pnpm format --check",
"format": "pnpm format:check --write",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does --write override the --check in the :check script?

bit cursed but i'll allow it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

P much

"format:check": "pnpm prettier --check --plugin-search-dir=. **/*.{cjs,mjs,ts,tsx,md,json} --ignore-path ../.gitignore --ignore-unknown --no-error-on-unmatched-pattern",
"release": "changeset version",
"pub:beta": "pnpm build && npm publish --tag beta",
"pub:next": "pnpm build && npm publish --tag next",
Expand Down
4 changes: 3 additions & 1 deletion cli/template/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
"dev": "next dev",
"build": "next build",
"start": "next start",
"lint": "next lint"
"lint": "next lint",
"format": "pnpm format:check --write",
FinnDore marked this conversation as resolved.
Show resolved Hide resolved
"format:check": "pnpm prettier --check --plugin-search-dir=. **/*.{cjs,mjs,ts,tsx,md,json} --ignore-path ../.gitignore --ignore-unknown --no-error-on-unmatched-pattern"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for these scripts

},
"dependencies": {
"next": "^13.2.4",
Expand Down