Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import order sorting via prettier #1392

Merged
merged 26 commits into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
split out installers
  • Loading branch information
FinnDore committed May 9, 2023
commit 68bd14152abbad30353882d3aae2307fc24b09f3
15 changes: 15 additions & 0 deletions cli/src/installers/eslint.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import fs from "fs-extra";
import path from "path";
import { PKG_ROOT } from "~/consts.js";
import { type Installer } from "./index.js";

export const eslint: Installer = ({ projectDir, packages }) => {
const configDir = path.join(PKG_ROOT, "template/extras/config");

fs.rmSync(path.join(projectDir, "_eslintrc.cjs"));

fs.copySync(
path.join(configDir, "_prettier.config.cjs"),
path.join(projectDir, "prettier.config.cjs"),
);
};
16 changes: 11 additions & 5 deletions cli/src/installers/index.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { envVariablesInstaller } from "~/installers/envVars.js";
import { nextAuthInstaller } from "~/installers/nextAuth.js";
import { prismaInstaller } from "~/installers/prisma.js";
import { strictEsLintAndPrettier } from "~/installers/strictEslintAndPrettier.js";
import { tailwindInstaller } from "~/installers/tailwind.js";
import { trpcInstaller } from "~/installers/trpc.js";
import { type PackageManager } from "~/utils/getUserPkgManager.js";
import { eslint } from "./eslint.js";
import { prettier } from "./prettier.js";

// Turning this into a const allows the list to be iterated over for programatically creating prompt options
// Should increase extensability in the future
Expand All @@ -14,7 +15,8 @@ export const availablePackages = [
"tailwind",
"trpc",
"envVariables",
"strictEslintAndPrettier",
"eslint",
"prettier",
] as const;
export type AvailablePackages = (typeof availablePackages)[number];

Expand Down Expand Up @@ -58,8 +60,12 @@ export const buildPkgInstallerMap = (
inUse: true,
installer: envVariablesInstaller,
},
strictEslintAndPrettier: {
inUse: packages.includes("strictEslintAndPrettier"),
installer: strictEsLintAndPrettier,
prettier: {
inUse: packages.includes("prettier"),
installer: prettier,
},
eslint: {
inUse: packages.includes("eslint"),
installer: eslint,
},
});
39 changes: 39 additions & 0 deletions cli/src/installers/prettier.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import fs from "fs-extra";
import path from "path";
import { PKG_ROOT } from "~/consts.js";
import { addPackageDependency } from "~/utils/addPackageDependency.js";
import { type Installer } from "../installers/index.js";
import { type AvailableDependencies } from "./dependencyVersionMap.js";

export const prettier: Installer = ({ projectDir, packages }) => {
const packeagesToInstall: AvailableDependencies[] = [
"prettier",
"@types/prettier",
"@ianvs/prettier-plugin-sort-imports",
];

if (packages?.tailwind.inUse) {
packeagesToInstall.push("prettier-plugin-tailwindcss");
}

addPackageDependency({
projectDir,
dependencies: packeagesToInstall,
devMode: true,
});

if (packages?.tailwind.inUse) {
fs.copySync(
path.join(
PKG_ROOT,
"template/extras/config/prettier-with-tailwind.config.cjs",
),
path.join(projectDir, "prettier.config.cjs"),
);
} else {
fs.copySync(
path.join(PKG_ROOT, "template/extras/config/prettier.config.cjs"),
path.join(projectDir, "prettier.config.cjs"),
);
}
};
41 changes: 0 additions & 41 deletions cli/src/installers/strictEslintAndPrettier.ts

This file was deleted.

20 changes: 1 addition & 19 deletions cli/src/installers/tailwind.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,7 @@ import { addPackageDependency } from "~/utils/addPackageDependency.js";
export const tailwindInstaller: Installer = ({ projectDir, packages }) => {
addPackageDependency({
projectDir,
dependencies: [
"tailwindcss",
"postcss",
"autoprefixer",
"prettier",
"prettier-plugin-tailwindcss",
"@types/prettier",
],
dependencies: ["tailwindcss", "postcss", "autoprefixer"],
devMode: true,
});

Expand All @@ -26,24 +19,13 @@ export const tailwindInstaller: Installer = ({ projectDir, packages }) => {
const postcssCfgSrc = path.join(extrasDir, "config/postcss.config.cjs");
const postcssCfgDest = path.join(projectDir, "postcss.config.cjs");

const prettierSrc = path.join(
extrasDir,
"config/prettier-with-tailwind.config.cjs",
);
const prettierDest = path.join(projectDir, "prettier.config.cjs");

const cssSrc = path.join(extrasDir, "src/styles/globals.css");
const cssDest = path.join(projectDir, "src/styles/globals.css");

fs.copySync(twCfgSrc, twCfgDest);
fs.copySync(postcssCfgSrc, postcssCfgDest);
fs.copySync(cssSrc, cssDest);

// Let strictEslintAndPrettier install the prettier config
if (!packages?.strictEslintAndPrettier.inUse) {
fs.copySync(prettierSrc, prettierDest);
}

// Remove vanilla css file
const indexModuleCss = path.join(projectDir, "src/pages/index.module.css");
fs.unlinkSync(indexModuleCss);
Expand Down
35 changes: 0 additions & 35 deletions cli/template/base/_eslintrc.cjs

This file was deleted.

This file was deleted.

Loading