feat: add import order sorting via prettier #1392

FinnDore · 2023-04-29T12:54:43Z

Closes #1332

✅ Checklist

I have followed every step in the contributing guide (updated 2022-10-06).
The PR title follows the convention we established conventional-commit
I performed a functional test on my final commit

Changelog

Added @ianvs/prettier-plugin-sort-import to the cli, docs and generated cta apps

Screenshots

it also seems to format code blocks which is cool

💯

changeset-bot · 2023-04-29T12:54:45Z

⚠️ No Changeset found

Latest commit: ab01b4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-04-29T12:54:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
create-t3-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2023 6:11pm

github-actions · 2023-04-29T12:54:56Z

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

FinnDore · 2023-04-29T12:54:57Z

need to actually test this on a generated app

FinnDore · 2023-04-29T12:59:42Z

Slight mis calculation, the base cta app does not actually include prettier....

we dont just want this to be available if you chose tailwind, however iirc the choice was made not to include prettier by default.

iAverages · 2023-04-29T22:40:27Z

Slight mis calculation, the base cta app does not actually include prettier....
we dont just want this to be available if you chose tailwind, however iirc the choice was made not to include prettier by default.

It should be pretty easy to add an option for prettier since it just needs installing + a single config. None of the other files change. I think that would probably be the best option here if installing it by default is a no go.

c-ehrlich · 2023-05-01T09:03:51Z

IMO we should have this either everywhere or nowhere. Limiting it to apps with Tailwind makes no sense. This would obviously mean including Prettier with all apps, but I think it might be worth it.

So I see three options:

Don't implement this
Ship a minimal prettier config to everyone
Add an option in the CLI that gives an opinionated prettier+eslint config

juliusmarminge · 2023-05-01T10:21:10Z

I think i vote 3

FinnDore · 2023-05-01T10:24:44Z

What would change about the eslint config? The default cta one has served my just fine tbh

juliusmarminge · 2023-05-01T10:26:04Z

What would change about the eslint config? The default cta one has served my just fine tbh

It would be either on or off i guess? Maybe add the prettier eslint config

We can add this too i think #1197

FinnDore · 2023-05-01T12:47:45Z

yeah that sounds good. will have a crack and we can see if its any good. A bit dubious of adding to many options.

vercel · 2023-05-05T13:20:36Z

@FinnDore is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

FinnDore · 2023-05-05T16:41:28Z

Think its done ( disregarding the sea of lint errors ). Im debating wether it should be prettierAndStrictEslint rather than strictPrettierAndEslint. or even if there should be two options?

I welcome thaughts.

…reate-t3-app into prettier-import-order

FinnDore · 2023-05-13T20:46:27Z

Removed the require.resolve from the tailwind prettier config as im not sure why it was needed, seems to work, somone lmk if its actually needed

FinnDore · 2023-05-13T20:52:57Z

Tested this all and i think its good to go now. although i thought that 4 days ago so im ready to be proven wrong.

juliusmarminge · 2023-05-16T06:29:39Z

Instead of having this as an installer next to the other pacakges, do you tihnk it'd be better to have like

? What pacakges would you like...
  o nextAuth
  ...

? Would you like to enable a more opinionated eslint+prettier setup?
  x yes o no

FinnDore · 2023-05-16T10:52:42Z

Good shout, maybe the wording should different though as it sounds like a more strict prettier config is added aswell which is wrong

FinnDore · 2023-05-16T17:51:42Z

I should probably update the ci aswell....

FinnDore · 2023-05-16T18:07:32Z

cant tell if ive borked the e2e workflow file or if it need approval to run since ive changes it

juliusmarminge · 2023-05-17T06:36:31Z

Merging to intermediate branch to release a canary

This reverts commit e1a5245.

juliusmarminge · 2023-05-17T06:38:47Z

bruh - based the intermediate branch off the wrong thing...

can you reopen 😄

open against the branch finn/eslint-prettier

FinnDore added 3 commits April 29, 2023 13:50

added import order sorting

b0f3b8b

cli format

d816992

format www

1149c08

FinnDore requested review from juliusmarminge, nexxeln, t3dotgg and c-ehrlich as code owners April 29, 2023 12:54

github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation labels Apr 29, 2023

vercel bot had a problem deploying to Preview April 29, 2023 12:56 Failure

.

882177e

vercel bot had a problem deploying to Preview – create-t3-app May 5, 2023 13:20 Failure

done?

760614a

vercel bot had a problem deploying to Preview – create-t3-app May 5, 2023 16:41 Failure

lint

d955bc2

vercel bot had a problem deploying to Preview – create-t3-app May 5, 2023 16:48 Failure

Merge branch 'prettier-import-order' of https://github.com/FinnDore/c…

976d21d

…reate-t3-app into prettier-import-order

vercel bot deployed to Preview – create-t3-app May 13, 2023 20:22 View deployment

removed uneeded resolve

db03947

vercel bot deployed to Preview – create-t3-app May 13, 2023 20:45 View deployment

docs update

63fad92

github-actions bot added the 📚 documentation Improvements or additions to documentation label May 14, 2023

vercel bot deployed to Preview – create-t3-app May 14, 2023 09:43 View deployment

Moved over to a seperate prompt

02b64de

vercel bot deployed to Preview – create-t3-app May 16, 2023 17:22 View deployment

yuh

7e77640

vercel bot deployed to Preview – create-t3-app May 16, 2023 17:56 View deployment

spelling

f16ce44

vercel bot deployed to Preview – create-t3-app May 16, 2023 18:02 View deployment

this?

ab01b4d

vercel bot deployed to Preview – create-t3-app May 16, 2023 18:11 View deployment

juliusmarminge mentioned this pull request May 16, 2023

Split eslint prettier #1422

Closed

juliusmarminge changed the base branch from next to finn/prettier May 17, 2023 06:36

juliusmarminge merged commit e1a5245 into t3-oss:finn/prettier May 17, 2023
4 of 6 checks passed

juliusmarminge added a commit that referenced this pull request May 17, 2023

Revert "feat: add import order sorting via prettier (#1392)"

966ab3e

This reverts commit e1a5245.

juliusmarminge mentioned this pull request May 17, 2023

Revert "feat: add import order sorting via prettier" #1424

Merged

juliusmarminge added a commit that referenced this pull request May 17, 2023

Revert "feat: add import order sorting via prettier (#1392)" (#1424)

e050339

This reverts commit e1a5245.

FinnDore mentioned this pull request May 17, 2023

feat: added an option for prettier and a extended eslint config #1425

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add import order sorting via prettier #1392

feat: add import order sorting via prettier #1392

FinnDore commented Apr 29, 2023

changeset-bot bot commented Apr 29, 2023 •

edited

vercel bot commented Apr 29, 2023 •

edited

github-actions bot commented Apr 29, 2023 •

edited

FinnDore commented Apr 29, 2023

FinnDore commented Apr 29, 2023 •

edited

iAverages commented Apr 29, 2023

c-ehrlich commented May 1, 2023

juliusmarminge commented May 1, 2023

FinnDore commented May 1, 2023

juliusmarminge commented May 1, 2023 •

edited

FinnDore commented May 1, 2023

vercel bot commented May 5, 2023

FinnDore commented May 5, 2023 •

edited

FinnDore commented May 13, 2023

FinnDore commented May 13, 2023

juliusmarminge commented May 16, 2023

FinnDore commented May 16, 2023

FinnDore commented May 16, 2023

FinnDore commented May 16, 2023

juliusmarminge commented May 17, 2023

juliusmarminge commented May 17, 2023 •

edited

feat: add import order sorting via prettier #1392

feat: add import order sorting via prettier #1392

Conversation

FinnDore commented Apr 29, 2023

✅ Checklist

Changelog

Screenshots

changeset-bot bot commented Apr 29, 2023 • edited

⚠️ No Changeset found

vercel bot commented Apr 29, 2023 • edited

github-actions bot commented Apr 29, 2023 • edited

FinnDore commented Apr 29, 2023

FinnDore commented Apr 29, 2023 • edited

iAverages commented Apr 29, 2023

c-ehrlich commented May 1, 2023

juliusmarminge commented May 1, 2023

FinnDore commented May 1, 2023

juliusmarminge commented May 1, 2023 • edited

FinnDore commented May 1, 2023

vercel bot commented May 5, 2023

FinnDore commented May 5, 2023 • edited

FinnDore commented May 13, 2023

FinnDore commented May 13, 2023

juliusmarminge commented May 16, 2023

FinnDore commented May 16, 2023

FinnDore commented May 16, 2023

FinnDore commented May 16, 2023

juliusmarminge commented May 17, 2023

juliusmarminge commented May 17, 2023 • edited

changeset-bot bot commented Apr 29, 2023 •

edited

vercel bot commented Apr 29, 2023 •

edited

github-actions bot commented Apr 29, 2023 •

edited

FinnDore commented Apr 29, 2023 •

edited

juliusmarminge commented May 1, 2023 •

edited

FinnDore commented May 5, 2023 •

edited

juliusmarminge commented May 17, 2023 •

edited