Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add sortable rows in ui/table component #5522

Merged
merged 4 commits into from
Nov 29, 2023
Merged

[Admin] Add sortable rows in ui/table component #5522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b21c42
Implement new `sortable_controller.js` with `sortable.js` and `rails/…
rainerdema Nov 29, 2023
5666ff2
Fix conditions to allow optional search bar functionality
rainerdema Nov 29, 2023
1a33703
Fix conditions to allow optional scopes functionality
rainerdema Nov 29, 2023
a0b8a40
Add sortable feature to `ui/table` component and update preview toggles
rainerdema Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix conditions to allow optional search bar functionality
  • Loading branch information
@rainerdema
rainerdema committed Nov 29, 2023
commit 5666ff2e75aa10008ce90962086eb3dcba741d56
120 changes: 61 additions & 59 deletions admin/app/components/solidus_admin/ui/table/component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,72 +12,74 @@
<%= component("ui/table/ransack_filter").stimulus_id %>:showSearch-><%= stimulus_id %>#showSearch
"
>
<div role="search">
<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "searchToolbar", hidden: initial_mode != "search") do %>
<%= form_with(
url: @search.url,
method: :get,
html: {
id: search_form_id,
class: 'flex-grow',
"data-turbo-action": "replace",
"data-#{stimulus_id}-target": "searchForm",
"data-action": "input->#{stimulus_id}#search change->#{stimulus_id}#search",
},
) do |form| %>
<%= hidden_field_tag @search.scope_param_name, @search.current_scope.name if @search.scopes.present? %>
<%= render component('ui/forms/search_field').new(
name: @search.searchbar_param_name,
value: @search.value[@search.searchbar_key],
placeholder: t('.search_placeholder', resources: @data.plural_name),
"aria-label": t('.search_placeholder', resources: @data.plural_name),
"data-#{stimulus_id}-target": "searchField",
"data-turbo-permanent": "true",
id: "#{stimulus_id}-search-field-#{@id}",
) %>
<% end %>
<% if @search %>
<div role="search">
<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "searchToolbar", hidden: initial_mode != "search") do %>
<%= form_with(
url: @search.url,
method: :get,
html: {
id: search_form_id,
class: 'flex-grow',
"data-turbo-action": "replace",
"data-#{stimulus_id}-target": "searchForm",
"data-action": "input->#{stimulus_id}#search change->#{stimulus_id}#search",
},
) do |form| %>
<%= hidden_field_tag @search.scope_param_name, @search.current_scope.name if @search.scopes.present? %>
<%= render component('ui/forms/search_field').new(
name: @search.searchbar_param_name,
value: @search.value[@search.searchbar_key],
placeholder: t('.search_placeholder', resources: @data.plural_name),
"aria-label": t('.search_placeholder', resources: @data.plural_name),
"data-#{stimulus_id}-target": "searchField",
"data-turbo-permanent": "true",
id: "#{stimulus_id}-search-field-#{@id}",
) %>
<% end %>

<div class="ml-4">
<%= render component("ui/button").new(
text: t('.cancel'),
scheme: :ghost,
"data-action": "#{stimulus_id}#cancelSearch",
) %>
</div>
<% end %>
<div class="ml-4">
<%= render component("ui/button").new(
text: t('.cancel'),
scheme: :ghost,
"data-action": "#{stimulus_id}#cancelSearch",
) %>
</div>
<% end %>

<% if @search.filters.any? %>
<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "filterToolbar", hidden: initial_mode != "search") do %>
<% @search.filters.each_with_index do |filter, index| %>
<%= render_ransack_filter_dropdown(filter, index) %>
<% if @search.filters.any? %>
<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "filterToolbar", hidden: initial_mode != "search") do %>
<% @search.filters.each_with_index do |filter, index| %>
<%= render_ransack_filter_dropdown(filter, index) %>
<% end %>
<% end %>
<% end %>
<% end %>

<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "scopesToolbar", hidden: initial_mode != "scopes") do %>
<div class="flex-grow">
<%= form_with(url: @search.url, method: :get) do %>
<% @search.scopes.each do |scope| %>
<%= render component("ui/tab").new(
tag: :button,
type: :submit,
text: scope.label,
current: scope == @search.current_scope,
name: @search.scope_param_name,
value: scope.name,
) %>
<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "scopesToolbar", hidden: initial_mode != "scopes") do %>
<div class="flex-grow">
<%= form_with(url: @search.url, method: :get) do %>
<% @search.scopes.each do |scope| %>
<%= render component("ui/tab").new(
tag: :button,
type: :submit,
text: scope.label,
current: scope == @search.current_scope,
name: @search.scope_param_name,
value: scope.name,
) %>
<% end %>
<% end %>
<% end %>
</div>
</div>

<%= render component("ui/button").new(
'aria-label': t('.filter'),
icon: "filter-3-line",
scheme: :secondary,
"data-action": "#{stimulus_id}#showSearch",
) %>
<% end %>
</div>
<%= render component("ui/button").new(
'aria-label': t('.filter'),
icon: "filter-3-line",
scheme: :secondary,
"data-action": "#{stimulus_id}#showSearch",
) %>
<% end %>
</div>
<% end %>

<%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "batchToolbar", role: "toolbar", "aria-label": t(".batch_actions"), hidden: true) do %>
<%= form_tag '', id: batch_actions_form_id %>
Expand Down
8 changes: 5 additions & 3 deletions admin/app/components/solidus_admin/ui/table/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default class extends Controller {
selectRow(event) {
if (this.checkboxTargets.some((checkbox) => checkbox.checked)) {
this.modeValue = "batch"
} else if (this.searchFieldTarget.value !== '') {
} else if (this.hasSearchFieldTarget && (this.searchFieldTarget.value !== '')) {
this.modeValue = "search"
} else {
this.modeValue = "scopes"
Expand All @@ -74,7 +74,7 @@ export default class extends Controller {
selectAllRows(event) {
if (event.target.checked) {
this.modeValue = "batch"
} else if (this.searchFieldTarget.value !== '') {
} else if (this.hasSearchFieldTarget && (this.searchFieldTarget.value !== '')) {
this.modeValue = "search"
} else {
this.modeValue = "scopes"
Expand Down Expand Up @@ -108,7 +108,9 @@ export default class extends Controller {
render() {
const selectedRows = this.checkboxTargets.filter((checkbox) => checkbox.checked)

this.searchToolbarTarget.toggleAttribute("hidden", this.modeValue !== "search")
if (this.hasSearchFieldTarget) {
this.searchToolbarTarget.toggleAttribute("hidden", this.modeValue !== "search")
}

if (this.hasFilterToolbarTarget) {
this.filterToolbarTarget.toggleAttribute("hidden", this.modeValue !== "search")
Expand Down
4 changes: 2 additions & 2 deletions admin/app/components/solidus_admin/ui/table/component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def initialize(id:, data:, search: nil)
@id = id
@data = Data.new(**data)
@data.columns.unshift selectable_column if @data.batch_actions.present?
@search = Search.new(**search)
@search = Search.new(**search) if search
end

def selectable_column
Expand Down Expand Up @@ -152,6 +152,6 @@ def current_scope_name
end

def initial_mode
@initial_mode ||= @search.value[@search.searchbar_key] ? "search" : "scopes"
@initial_mode ||= @search && @search.value[@search.searchbar_key] ? "search" : "scopes"
elia marked this conversation as resolved.
Show resolved Hide resolved
end
end