Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add sortable rows in ui/table component #5522

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Nov 28, 2023

Summary

Admin.Add.sortable.rows.in.ui.table.component.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema self-assigned this Nov 28, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/add-sortable-lists branch 3 times, most recently from d998c2a to 5560714 Compare November 29, 2023 15:41
@rainerdema rainerdema force-pushed the rainerd/admin/add-sortable-lists branch from 5560714 to 88f6467 Compare November 29, 2023 15:41
- Integrate sorting rows functionality with the 
`sortable_controller.js`.
- Enhanced the preview section to allow enabling and disabling all table
  functionalities, including sorting, search, filters, batch actions,
  and scopes.
@rainerdema rainerdema force-pushed the rainerd/admin/add-sortable-lists branch 2 times, most recently from 785f423 to a0b8a40 Compare November 29, 2023 16:12
@rainerdema rainerdema changed the title [Admin] Add sortable rows in ui/table component + create new option types index component [Admin] Add sortable rows in ui/table component Nov 29, 2023
@rainerdema rainerdema marked this pull request as ready for review November 29, 2023 16:34
@rainerdema rainerdema requested a review from a team as a code owner November 29, 2023 16:34
@rainerdema rainerdema requested a review from elia November 29, 2023 16:34
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Awesome!

@rainerdema rainerdema merged commit 0bbb702 into solidusio:main Nov 29, 2023
8 checks passed
@rainerdema rainerdema deleted the rainerd/admin/add-sortable-lists branch November 29, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants