Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add sortable rows in ui/table component #5522

Merged
merged 4 commits into from
Nov 29, 2023
Merged

[Admin] Add sortable rows in ui/table component #5522

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b21c42
Implement new `sortable_controller.js` with `sortable.js` and `rails/…
rainerdema Nov 29, 2023
5666ff2
Fix conditions to allow optional search bar functionality
rainerdema Nov 29, 2023
1a33703
Fix conditions to allow optional scopes functionality
rainerdema Nov 29, 2023
a0b8a40
Add sortable feature to `ui/table` component and update preview toggles
rainerdema Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix conditions to allow optional scopes functionality
  • Loading branch information
@rainerdema
rainerdema committed Nov 29, 2023
commit 1a337032fed2522bc7e39dbcd7339b8b8fb54e51
4 changes: 3 additions & 1 deletion admin/app/components/solidus_admin/ui/table/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ export default class extends Controller {
this.batchHeaderTarget.toggleAttribute("hidden", this.modeValue !== "batch")
this.defaultHeaderTarget.toggleAttribute("hidden", this.modeValue === "batch")

this.scopesToolbarTarget.toggleAttribute("hidden", this.modeValue !== "scopes")
if (this.hasScopesToolbarTarget) {
this.scopesToolbarTarget.toggleAttribute("hidden", this.modeValue !== "scopes")
}

// Update the rows background color
this.checkboxTargets.filter((checkbox) =>
Expand Down