Remove unintentional failing spec addition #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was accidentally added -- probably while resolving a merge conflict while bringing this change from master: solidusio@80d3316#diff-bcc8495cd68d136981bdf1f391bce4c0 into this change in the v2.3 branch: solidusio@837d1fc#diff-bcc8495cd68d136981bdf1f391bce4c0 This method is not deprecated in v2.3 so the spec will fail. Additionally, it appears in v2.4+ the deprecation has unintentionally made the method public. We can look into that separately.
houndci-bot
reviewed
Dec 13, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming Error: The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. (obsolete configuration found in .rubocop.yml, please update it)
|
Thanks |
|
For the record: Here's the PR to address the method-visibility issue: #2449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was accidentally added -- probably while resolving a merge
conflict while bringing this change from master:
80d3316#diff-bcc8495cd68d136981bdf1f391bce4c0
into this change in the v2.3 branch:
837d1fc#diff-bcc8495cd68d136981bdf1f391bce4c0
This method is not deprecated in v2.3 so the spec will fail.
Additionally, it appears in v2.4+ the deprecation has unintentionally made the
method public. We can look into that separately.