Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unintentional failing spec addition #2448

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Remove unintentional failing spec addition #2448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unintentional failing spec addition 
I believe this was accidentally added -- probably while resolving a merge
conflict while bringing this change from master:
80d3316#diff-bcc8495cd68d136981bdf1f391bce4c0
into this change in the v2.3 branch:
837d1fc#diff-bcc8495cd68d136981bdf1f391bce4c0

This method is not deprecated in v2.3 so the spec will fail.

Additionally, it appears in v2.4+ the deprecation has unintentionally made the
method public. We can look into that separately.
  • Loading branch information
@jordan-brough
jordan-brough committed Dec 13, 2017
commit ce6e5e1eceed09fa299a4dd788f61e444b219995
10 changes: 0 additions & 10 deletions core/spec/models/spree/order_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,16 +1535,6 @@ def generate
end
end

context 'update_params_payment_source' do
subject { described_class.new }

it 'is deprecated' do
subject.instance_variable_set('@updating_params', {})
expect(Spree::Deprecation).to receive(:warn)
subject.update_params_payment_source
end
end

describe "#validate_payments_attributes" do
let(:attributes) { [ActionController::Parameters.new(payment_method_id: payment_method.id)] }
subject do
Expand Down