Avoid changing method visibility when deprecating a method #2449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport::Deprecation::MethodWrapper#deprecate_methods
changes methodvisibility to
public
. This seems unintentional and I will submit a PR toRails to see if that can be updated.
For the meanwhile, this update changes method visibility back to the original
visibility. It's a bit more convoluted than might be expected because
ActiveSupport uses
Module.prepend
to override the original method, so we can'tjust write
private :some_method
because that only affects the original method,whose visibility has not been changed.
If people think it's worth creating a helper for this let me know and I will do so.