Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bruno icon #11101

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

CodeShakingSheep
Copy link
Contributor

@CodeShakingSheep CodeShakingSheep commented Jun 3, 2024

image

Issue: closes #10929

Popularity metric:

The Similarweb rank is 336,408. See https://www.similarweb.com/website/usebruno.com
Also, Bruno has ~20.9k stars on GitHub. See https://github.com/usebruno/bruno

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Downloaded svg from website's header, removed colors, converted strokes, unified paths, resized, optimized.

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jun 3, 2024
uncenter

This comment was marked as outdated.

@CodeShakingSheep
Copy link
Contributor Author

Seeing differences around the jaw and in the eyes.

Thanks for the review. I redid the icon carefully converting all strokes first. Is it better now?

uncenter

This comment was marked as outdated.

@CodeShakingSheep
Copy link
Contributor Author

Red is your path, on top of the black line from the original SVG. If anything it uh... looks worse than the previous iteration. This is really tough though so I don't blame you at all, stroke to path conversations are awfully inaccurate.

Here's one that isn't perfect (left jaw has some differences) but looks passable to me:

<svg role="img" viewBox="0 0 24 24" xmlns="http:https://www.w3.org/2000/svg"><title>Bruno</title><path d="M11.87483 1.55743c-.37669-.0024-.73821.0199-1.08403.06055-1.8163.21343-3.13706.89417-3.80873 1.33403-.1067.00195-.24108-.00716-.57229.08008-.43521.11464-1.03078.35236-1.7071.83597-1.3526.96722-3.02245 2.90407-4.48844 6.76001-.48674 1.28028-.07713 2.71435.55862 4.00796s1.52909 2.47633 2.19734 3.2677c.5935.70286 1.75293.54782 2.14657-.28126l.13281-.27736c.5226.82582 1.57882 2.19372 3.088 2.6876a.47224.47224 0 0 0 .59573-.3008.47224.47224 0 0 0-.30274-.59572c-1.55087-.50752-2.75902-2.6007-2.88878-2.83213l.1875-.3926c.12927-.2723.16085-.5842.08204-.87893-.24686-.92335-.90908-4.09729-.07422-5.95334a.47224.47224 0 0 0-.23829-.62503.47224.47224 0 0 0-.62307.23634c-1.05759 2.35121-.24223 5.59054.02344 6.58423v.002c.02085.07799.0128.15412-.02344.23047l-.81058 1.709c-.1153.24285-.4018.28233-.57424.07813-.63557-.75266-1.48946-1.89228-2.07038-3.07433-.58093-1.18206-.85763-2.37702-.52346-3.25598 1.41872-3.7316 2.98957-5.49399 4.1564-6.32836.58341-.41718 1.06726-.6047 1.39654-.69143s.46095-.07422.46095-.07422a.4723.4723 0 0 0 .29103-.08008c.5195-.35239 1.8042-1.03513 3.50012-1.23442 1.69593-.1993 3.80817.06227 6.10765 1.5938a.4723.4723 0 0 0 .35353.07032s.12293-.03061.43165.01368c.30873.04428.76077.16893 1.30474.51955 1.08794.70123 2.56103 2.32408 3.82631 6.06076.3022.89246.0148 2.0934-.56057 3.2716-.57537 1.17822-1.40956 2.3095-2.03132 3.06067-.17093.2065-.46039.16773-.5762-.07617l-.47071-.99027a.47.47 0 0 0-.02148-.04492l-.31252-.66214c-.0362-.07625-.04428-.1525-.02343-.23047.26572-.99371 1.08102-4.23494.02343-6.58618a.47224.47224 0 0 0-.62502-.23634.47224.47224 0 0 0-.23634.62502c.83488 1.8561.17267 5.0301-.07422 5.95334-.0788.29474-.04727.6066.08203.87894l.23048.4844c-.12602.24312-.37402.69026-.72854 1.17777-.5265.724-1.27978 1.48947-2.0821 1.75202a.47224.47224 0 0 0-.30275.59572.47224.47224 0 0 0 .59572.3008c1.12836-.36924 1.96998-1.28967 2.55478-2.09383.17746-.24403.32846-.47806.45705-.68948l.08203.17188c.39566.83333 1.5646.98396 2.15438.2715.65298-.7889 1.5245-1.96234 2.15242-3.24817s1.04193-2.70724.60744-3.99038c-1.3101-3.86905-2.89027-5.699-4.20913-6.54907-.65943-.42504-1.24884-.60004-1.6817-.66214-.31902-.04576-.44002-.017-.55276-.0039-1.96954-1.26835-3.86986-1.72598-5.50215-1.7364M8.7126 8.35846c-.27591-.00027-.54525.1402-.69924.39259-.23466.38459-.1119.8869.27344 1.12113.3853.23423 1.12114-.27344 1.12114-.27344s.11384-.88691-.2715-1.12114a.816.816 0 0 0-.42384-.11914m7.4202 0a.816.816 0 0 0-.42385.11914c-.38533.23423-.2715 1.12114-.2715 1.12114s.7358.50767 1.12114.27344.5081-.73654.27345-1.12113c-.154-.25241-.42333-.39287-.69925-.3926m-5.25215 3.5802c-.36515 0-.6956.2284-.82425.57034l-.44533 1.18364a.4723.4723 0 0 0 .26173.60353l.94535.38869c.50885.20903 1.10318-.11645 1.20121-.65823a.47224.47224 0 0 0-.38087-.54885.47224.47224 0 0 0-.50588.31447l-.47658-.19532.26759-.71292h2.42587l.28517.66995-.4551.24024a.47224.47224 0 0 0-.48634-.33204.47224.47224 0 0 0-.40627.52932c.07858.59233.75259.9415 1.2813.66408l.89066-.46681a.4723.4723 0 0 0 .21485-.60354l-.47268-1.11137c-.13786-.32382-.45895-.53517-.81057-.53517zm-2.9962 2.3829a.47224.47224 0 0 0-.52932.40627c-.11387.862.16681 1.5957.584 2.13094.4025.51637.91797.86772 1.36334 1.10941-.01426.35174-.02217.98448.06055 1.66022.06203.50682.17287 1.0385.39259 1.51177.21971.47327.5765.91454 1.12309 1.08207.5948.18232 1.17248.24375 1.67193.2129.49946-.03085.92271-.1262 1.25005-.40626.35342-.30238.58003-.78495.77932-1.52936.17343-.64776.27388-1.472.18165-2.42.06101-.02458.12084-.05274.1797-.08399.45605-.24219.99496-.60152 1.41216-1.13676.41719-.53524.69787-1.26893.584-2.13093a.47224.47224 0 0 0-.53127-.40627.47224.47224 0 0 0-.40626.52931c.08014.60671-.0956 1.04481-.3926 1.42584-.29698.38102-.72797.68222-1.10941.8848-.08185.04346-.16683.07385-.25392.0918a.47.47 0 0 0-.07617 0 .47.47 0 0 0-.05664.01757c-.21947.01325-.43864-.05212-.61916-.19336l-.87308-.68362V15.388a.47224.47224 0 0 0-.47267-.47072.47224.47224 0 0 0-.47268.47072v1.0059l-.87307.68362c-.28879.22597-.67842.25789-1.0059.08398-.38145-.20256-.81439-.50377-1.11138-.8848s-.47273-.81912-.39259-1.42583a.47224.47224 0 0 0-.40626-.52932m4.26187 2.90245.7637.59768c.27045.2116.5871.33613.9141.37697.07618.81899-.01281 1.52094-.15626 2.05671-.16668.6226-.4765 1.05133-.48049 1.05473-.0455.03893-.32005.16042-.69533.1836-.37529.02318-.85007-.02489-1.33599-.17383-.21435-.0657-.39167-.24802-.54494-.57815s-.25575-.7808-.31056-1.22856c-.05997-.48999-.06685-.96368-.06055-1.29692.40613-.001.8095-.13388 1.14262-.39455z"/></svg>

Oh ok. I don't know why it got worse. I think I did almost the same steps in Inkscape as before just catching all strokes to convert (of which I might have missed some in the first iteration). I checked your path and it looks good to me. So, I will push a commit of that in a few minutes.

@uncenter
Copy link
Member

uncenter commented Jun 4, 2024

Sweet. Let's see if anyone else can come up with a better version or if this is alright, nothing else you need to do for this PR :)

icons/bruno.svg Outdated Show resolved Hide resolved
@adamrusted adamrusted requested a review from uncenter June 11, 2024 15:08
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon looks good! Just that one question about the brand capitalization.

_data/simple-icons.json Show resolved Hide resolved
@adamrusted adamrusted merged commit d803312 into simple-icons:develop Jun 12, 2024
3 checks passed
simple-icons bot added a commit that referenced this pull request Jun 16, 2024
# New Icons

- Anki (#10708) (@uncenter)
- Astra (#11118) (@CodeShakingSheep)
- Bruno (#11101) (@CodeShakingSheep)
- comma (#11034) (@21st-centuryman)
- DATEV (#11160) (@CodeShakingSheep)
- Doctrine (#11064) (@CodeShakingSheep)
- Duplicati (#11072) (@anhthang)
- Picrew (#11068) (@anhthang)
- pino (#10852) (@10xLaCroixDrinker)
- Rime (#11181) (@anhthang)
- Tower (#11170) (@anhthang)
- TypeORM (#10939) (@davesagraf)
- Wagmi (#11065) (@anhthang)
- yabai (#10997) (@anhthang)
- YunoHost (#10947) (@CodeShakingSheep)

# Updated Icons

- GNOME (#11155) (@LitoMore)
- Render (#11130) (@adamrusted)
@CodeShakingSheep CodeShakingSheep deleted the add-bruno-icon branch June 25, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Bruno
3 participants