Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Comma icon #11034

Merged
merged 17 commits into from
Jun 12, 2024
Merged

Add Comma icon #11034

merged 17 commits into from
Jun 12, 2024

Conversation

21st-centuryman
Copy link
Contributor

Issue: closes #11033

Popularity metric:

similarweb

227,534

they also maintain openpilot

48.2 ✨

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I believe their main color is green, judging from all the green used in their events and website. I grabbed the following from the header of their website: 51FF00

As with the logo i used the vector found in their app repository:
https://github.com/commaai/connect/blob/master/public/icon-vector.svg

image

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label May 27, 2024
@21st-centuryman 21st-centuryman changed the title Comma Add Comma May 27, 2024
uncenter
uncenter requested changes May 27, 2024
View reviewed changes
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the logo i used the vector found in their app repository: https://github.com/commaai/connect/blob/master/public/icon-vector.svg

This should be listed as the source then?

@uncenter uncenter changed the title Add Comma Add Comma icon May 27, 2024
@21st-centuryman
Copy link
Contributor Author

@uncenter I am not sure if it could apply here. I was confused by all other companies having the official website as their source, i could probably find a better source if thats what you want.

@uncenter
Copy link
Member

uncenter commented May 27, 2024 •
edited
Loading

@uncenter I am not sure if it could apply here. I was confused by all other companies having the official website as their source, i could probably find a better source if thats what you want.

Please see https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#source-guidelines for how we determine sources. I'm not saying you need a better source, I was just confused why you said you used one SVG as your base but then listed another. If you based it on the GitHub SVG, you should update the data file to use that link instead.

@21st-centuryman
Copy link
Contributor Author

@uncenter thank you for your explanation, this has now been fixed.

uncenter
uncenter approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@uncenter uncenter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a slight difference when compared to the original with the difference tool near the bottom of the comma symbol though it looks fine in general. Might want to try touching that up a bit, otherwise good to go.

@21st-centuryman
Copy link
Contributor Author

21st-centuryman commented Jun 3, 2024 •
edited
Loading

Sorry i didnt realize i accidentally force pushed. i have a new updated icon in the pr for you to checkout
@uncenter

@adamrusted adamrusted requested a review from uncenter June 7, 2024 08:32
@uncenter
Copy link
Member

uncenter commented Jun 7, 2024

I'd like to review this again but something is up with this PR/branch specifically - I've had no issues with gh pr checkout except with gh pr checkout 11034...

@uncenter
Copy link
Member

uncenter commented Jun 7, 2024

Ah, it's working now. I'll review.

uncenter
uncenter requested changes Jun 7, 2024
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/comma.svg Outdated Show resolved Hide resolved
@21st-centuryman
Copy link
Contributor Author

@uncenter added your changes.

If there is nothing else for me to change, I hope you have a great weekend.

@uncenter
Copy link
Member

uncenter commented Jun 7, 2024

@uncenter added your changes.

If there is nothing else for me to change, I hope you have a great weekend.

I think that is it! Thanks for adding this 🚀

uncenter
uncenter requested changes Jun 7, 2024
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
adamrusted
adamrusted requested changes Jun 10, 2024
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/comma.svg Show resolved Hide resolved
uncenter
uncenter previously requested changes Jun 12, 2024
View reviewed changes
icons/comma.svg Show resolved Hide resolved
uncenter
uncenter reviewed Jun 12, 2024
View reviewed changes
icons/comma.svg Outdated Show resolved Hide resolved
@21st-centuryman @uncenter
Add: @uncenter icon
b15eeb9 
Co-authored-by: uncenter <[email protected]>
adamrusted
adamrusted reviewed Jun 12, 2024
View reviewed changes
icons/comma.svg Outdated Show resolved Hide resolved
adamrusted
adamrusted approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @21st-centuryman and @uncenter!

@adamrusted adamrusted merged commit 052da97 into simple-icons:develop Jun 12, 2024
3 checks passed
@simple-icons simple-icons bot mentioned this pull request Jun 16, 2024
Merged
simple-icons bot added a commit that referenced this pull request Jun 16, 2024
@simple-icons
Release 15 new icons and 2 updated icons (v12.3.0)
fa3e307 
# New Icons

- Anki (#10708) (@uncenter)
- Astra (#11118) (@CodeShakingSheep)
- Bruno (#11101) (@CodeShakingSheep)
- comma (#11034) (@21st-centuryman)
- DATEV (#11160) (@CodeShakingSheep)
- Doctrine (#11064) (@CodeShakingSheep)
- Duplicati (#11072) (@anhthang)
- Picrew (#11068) (@anhthang)
- pino (#10852) (@10xLaCroixDrinker)
- Rime (#11181) (@anhthang)
- Tower (#11170) (@anhthang)
- TypeORM (#10939) (@davesagraf)
- Wagmi (#11065) (@anhthang)
- yabai (#10997) (@anhthang)
- YunoHost (#10947) (@CodeShakingSheep)

# Updated Icons

- GNOME (#11155) (@LitoMore)
- Render (#11130) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter left review comments

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Comma
3 participants
@21st-centuryman @uncenter @adamrusted