Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yabai icon #10997

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Add yabai icon #10997

merged 11 commits into from
Jun 12, 2024

Conversation

anhthang
Copy link
Contributor

@anhthang anhthang commented May 22, 2024

Yabai icon

Issue: closes #10968

Popularity metric:

22k ⭐ on GitHub

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hex value is from original svg here: https://github.com/koekeishiya/yabai/blob/86c759186d7c588dfd8c6a84aac1ebc4730e988e/assets/icon/icon.svg

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label May 22, 2024
icons/yabai.svg Outdated Show resolved Hide resolved
@anhthang anhthang requested a review from uncenter May 24, 2024 10:47
@anhthang
Copy link
Contributor Author

@uncenter Are there any additional changes needed for this pull request to be merged?

@uncenter
Copy link
Member

uncenter commented May 27, 2024

@uncenter Are there any additional changes needed for this pull request to be merged?

Nope, just waiting on another reviewer. The icon looks perfect!

@uncenter
Copy link
Member

No need to update this branch, it just pings us and we'll have to update it again before merging anyway.

icons/yabai.svg Outdated Show resolved Hide resolved
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, whatever you did added more differences!
image

See the lines between the y shape and the diamond. Ideally they should be removed so it's just one solid path.

@anhthang
Copy link
Contributor Author

@adamrusted I slightly modified the green path to make it easier to combine it seamlessly with the Y shape. There shouldn't be any significant changes compared to the previous version. Could you please review it again to see if the issue is resolved?

@anhthang anhthang requested a review from adamrusted June 11, 2024 16:25
icons/yabai.svg Outdated Show resolved Hide resolved
@anhthang anhthang requested a review from adamrusted June 12, 2024 07:28
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! We've gotten there! Thanks for your patience @anhthang!

@adamrusted adamrusted merged commit b93495e into simple-icons:develop Jun 12, 2024
3 checks passed
@anhthang anhthang deleted the yabai branch June 13, 2024 00:54
simple-icons bot added a commit that referenced this pull request Jun 16, 2024
# New Icons

- Anki (#10708) (@uncenter)
- Astra (#11118) (@CodeShakingSheep)
- Bruno (#11101) (@CodeShakingSheep)
- comma (#11034) (@21st-centuryman)
- DATEV (#11160) (@CodeShakingSheep)
- Doctrine (#11064) (@CodeShakingSheep)
- Duplicati (#11072) (@anhthang)
- Picrew (#11068) (@anhthang)
- pino (#10852) (@10xLaCroixDrinker)
- Rime (#11181) (@anhthang)
- Tower (#11170) (@anhthang)
- TypeORM (#10939) (@davesagraf)
- Wagmi (#11065) (@anhthang)
- yabai (#10997) (@anhthang)
- YunoHost (#10947) (@CodeShakingSheep)

# Updated Icons

- GNOME (#11155) (@LitoMore)
- Render (#11130) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: yabai
3 participants