feat: Implement miles/kilometer selector #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amaury1093
reviewed
Oct 6, 2019
There was a problem hiding this comment.
Thanks @matepapp for this wonderful PR! It works perfectly.
I just added some comments on the code. 95% are just nits, I tend to order stuff alphabetically if I don't see any other more logical ordering.
And you're right about linting, sorry about that, Prettier is a good idea. And those 95% of nits above should be definitely enforced by a linter. I created an issue for that #253
| DistanceUnit | ||
| } from '../../util/station'; | ||
| import { distanceToStation, getCorrectLatLng } from '../../util/station'; | ||
| import { useDistanceUnit } from '../../stores/distanceUnit'; |
amaury1093
changed the title
Co-Authored-By: Amaury Martiny <[email protected]>
|
No problem, thanks for the comments 🙌 I think I fixed everything but double check it please. |
amaury1093
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #244
Prettier
I tried to infer the project's code formatting rules, but I couldn't figure it out completely, that's why I additionally created aprettierrcto configure prettier. If it's too much, please comment on it and I'll remove.Ohh I've just found an issue why you might didn't want to use prettier at the first case. I removed the prettier config and sorry if I messed up your formatting 😶
Screen recording