Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement miles/kilometer selector #252

Merged
merged 11 commits into from
Oct 6, 2019
Merged

feat: Implement miles/kilometer selector #252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1fef766
feat: extend i18n data with distance
matepapp Oct 5, 2019
cb4f84e
feat: implement initial switch logic and styling
matepapp Oct 5, 2019
b181ffc
chore: add prettier config file
matepapp Oct 5, 2019
9ffc59a
feat: extend translations with distance
matepapp Oct 5, 2019
e9f80e0
feat: create DistanceUnit Store
matepapp Oct 5, 2019
97853e6
refactor: use new DistanceUnit Store
matepapp Oct 5, 2019
b457cc9
fix: add missing whitespaces
matepapp Oct 5, 2019
48c5420
chore: remove prettierrc
matepapp Oct 5, 2019
699dfbf
Update App/stores/distanceUnit.tsx
matepapp Oct 6, 2019
f67dcdd
fix: resolve review's comments
matepapp Oct 6, 2019
a9bedb4
fix: resolve lint errors
matepapp Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: extend i18n data with distance
  • Loading branch information
@matepapp
matepapp committed Oct 5, 2019
commit 1fef76612527fa9e613ef5427481e2a0c4dcb8a0
3 changes: 2 additions & 1 deletion App/localization/languages/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"about_weird_results_message_1": "We have also encountered a few surprising results: large cities with better air than small villages; sudden huge increases in the number of cigarettes; stations of the same town showing significantly different numbers... The fact is air quality depends on several factors such as temperature, pressure, humidity and even wind direction and intensity. If the result seems weird for you, check",
"about_weird_results_link_1": "WAQI",
"about_weird_results_message_2": "for more information and history on your station.",
"about_distance_title": "Distance",
"about_credits_title": "Credits",
"about_credits_concept_and_development": "Concept & Development by",
"about_credits_design_and_copywriting": "Design & Copywriting by",
Expand All @@ -84,4 +85,4 @@
"about_credits_available_github": "available on Github",
"about_language": "Language",
"current_location_unknown_station": "Unknown AQI station"
}
}
3 changes: 2 additions & 1 deletion App/localization/languages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"about_weird_results_message_1": "We have also encountered a few surprising results: large cities with better air than small villages; sudden huge increases in the number of cigarettes; stations of the same town showing significantly different numbers... The fact is air quality depends on several factors such as temperature, pressure, humidity and even wind direction and intensity. If the result seems weird for you, check",
"about_weird_results_link_1": "WAQI",
"about_weird_results_message_2": "for more information and history on your station.",
"about_distance_title": "Distance",
"about_credits_title": "Credits",
"about_credits_concept_and_development": "Concept & Development by",
"about_credits_design_and_copywriting": "Design & Copywriting by",
Expand All @@ -84,4 +85,4 @@
"about_credits_available_github": "available on Github",
"about_language": "Language",
"current_location_unknown_station": "Unknown AQI station"
}
}