Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to change between miles and km #244

Closed
amaury1093 opened this issue Oct 3, 2019 · 5 comments · Fixed by #252
Closed

Allow users to change between miles and km #244

amaury1093 opened this issue Oct 3, 2019 · 5 comments · Fixed by #252
Assignees
@hendaoui @matepapp
Labels
F-planned New feature or request good first issue Good for newcomers

Comments

@amaury1093
Copy link
Member

Right now, it's showing mi when user's language is en-US, and km everywhere else.

My phone is en-US, but I use km. I would like to be able to configure that.

This setting should be saved in AsyncStorage.

For the UI, I think for now a simple Switch in the About.tsx screen would do.
@amaury1093 amaury1093 added F-planned New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 3, 2019
@hendaoui
Copy link

hendaoui commented Oct 3, 2019

Working on it 👍

@hendaoui
Copy link

hendaoui commented Oct 4, 2019

I'm not managing to get API keys, do you have test keys or can you help me generate new ones!

@amaury1093
Copy link
Member Author

@hendaoui I just emailed you some new keys that I generated.

@matepapp
Copy link
Contributor

matepapp commented Oct 5, 2019

hey @hendaoui, are you still working on it? I'm willing to help or implement if you don't

@hendaoui
Copy link

hendaoui commented Oct 5, 2019

@matepapp feel free to work on it (unfortunately I didn't have enough time)

@matepapp matepapp mentioned this issue Oct 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hendaoui hendaoui

@matepapp matepapp

Labels
F-planned New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement miles/kilometer selector matepapp/shoot-i-smoke
3 participants
@amaury1093 @hendaoui @matepapp