Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement miles/kilometer selector #252

Merged
merged 11 commits into from
Oct 6, 2019
Merged

feat: Implement miles/kilometer selector #252

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1fef766
feat: extend i18n data with distance
matepapp Oct 5, 2019
cb4f84e
feat: implement initial switch logic and styling
matepapp Oct 5, 2019
b181ffc
chore: add prettier config file
matepapp Oct 5, 2019
9ffc59a
feat: extend translations with distance
matepapp Oct 5, 2019
e9f80e0
feat: create DistanceUnit Store
matepapp Oct 5, 2019
97853e6
refactor: use new DistanceUnit Store
matepapp Oct 5, 2019
b457cc9
fix: add missing whitespaces
matepapp Oct 5, 2019
48c5420
chore: remove prettierrc
matepapp Oct 5, 2019
699dfbf
Update App/stores/distanceUnit.tsx
matepapp Oct 6, 2019
f67dcdd
fix: resolve review's comments
matepapp Oct 6, 2019
a9bedb4
fix: resolve lint errors
matepapp Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update App/stores/distanceUnit.tsx 
Co-Authored-By: Amaury Martiny <[email protected]>
  • Loading branch information
@matepapp @amaury1093
matepapp and amaury1093 committed Oct 6, 2019
commit 699dfbf8e748b53cf2861a06fbf11f3f9d6aa9ef
2 changes: 1 addition & 1 deletion App/stores/distanceUnit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const DistanceUnitProvider: FC = ({ children }) => {

const getDistanceUnit = async (): Promise<void> => {
const unit = await AsyncStorage.getItem(STORAGE_KEY);
if ((unit && unit === 'km') || (unit && unit === 'mile')) {
if (unit === 'km' || unit === 'mile') {
setDistanceUnit(unit);
}
};
Expand Down