Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp.highly_variable_genes handles subset and inplace consistently #2757

Merged
merged 16 commits into from
Dec 4, 2023

Conversation

eroell
Copy link
Contributor

@eroell eroell commented Nov 16, 2023

  • Release notes not necessary because: Added entry in release notes.

Addresses issue #1867 with a fix as outlined by @jlause and tests which catch the failure mode detected and nicely demonstrated by @jlause.

@eroell eroell changed the title sc.pp.select_highly_variable_genes to handle subset and inplace consistently sc.pp.highly_variable_genes to handle subset and inplace consistently Nov 16, 2023
@eroell eroell modified the milestone: 1.9.7 Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2757 (ac419a2) into master (bc349b9) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2757   +/-   ##
=======================================
  Coverage   72.46%   72.47%           
=======================================
  Files         111      111           
  Lines       12418    12422    +4     
=======================================
+ Hits         8999     9003    +4     
  Misses       3419     3419           
Files Coverage Δ
scanpy/preprocessing/_highly_variable_genes.py 96.03% <83.33%> (+0.07%) ⬆️

@flying-sheep flying-sheep added this to the 1.9.7 milestone Nov 17, 2023
@flying-sheep flying-sheep changed the title sc.pp.highly_variable_genes to handle subset and inplace consistently pp.highly_variable_genes handles subset and inplace consistently Dec 4, 2023
@flying-sheep flying-sheep merged commit 822b151 into scverse:master Dec 4, 2023
11 checks passed
@flying-sheep flying-sheep removed their request for review December 4, 2023 07:52
flying-sheep pushed a commit that referenced this pull request Dec 4, 2023
@scverse scverse deleted a comment from lumberbot-app bot Dec 4, 2023
flying-sheep added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sc.pp.highly_variable does not always handle subset and inplace arguments consistently
2 participants